194581 - integrate s100 ess updatesince endpoint to scs stub #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MastekRohitChettri
requested review from
harshal11869,
Nadeem14456 and
shirinbt14926
…since-to-scs-stub
…-ess-s100-updatesince-to-scs-stub
…dev/194581-integrate-ess-s100-updatesince-to-scs-stub
…-ess-s100-updatesince-to-scs-stub
…since-to-scs-stub
added 2 commits
January 8, 2025 22:32
https://github.com/UKHO/exchange-set-service into dev/194581-integrate-ess-s100-updatesince-to-scs-stub
⛔ Snyk checks have failed. 2 issues have been found so far.
⛔ code/snyk check is complete. 2 issues have been found. (View Details) |
ukho-bot
reviewed
Jan 8, 2025
...SetService.API/UKHO.ExchangeSetService.Common.UnitTests/Helpers/SalesCatalogueClientTests.cs
Outdated
Show resolved
Hide resolved
UKHO.ExchangeSetService.API/UKHO.ExchangeSetService.API/Controllers/V2/ExchangeSetController.cs
Outdated
Show resolved
Hide resolved
ukho-bot
reviewed
Jan 10, 2025
UKHO.ExchangeSetService.API/UKHO.ExchangeSetService.API/Controllers/V2/ExchangeSetController.cs
Outdated
Show resolved
Hide resolved
https://github.com/UKHO/exchange-set-service into dev/194581-integrate-ess-s100-updatesince-to-scs-stub
…d response AB#194581 AB#197779
https://github.com/UKHO/exchange-set-service into dev/194581-integrate-ess-s100-updatesince-to-scs-stub
harshal11869
requested changes
Jan 14, 2025
UKHO.ExchangeSetService.API/UKHO.ExchangeSetService.Common/Helpers/V2/ISalesCatalogueService.cs
Outdated
Show resolved
Hide resolved
jrippington
approved these changes
Jan 15, 2025
jrippington
deleted the
dev/194581-integrate-ess-s100-updatesince-to-scs-stub
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists changes for PBI : 194581