Disable XML transformation in CI/CD pipelines #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `FileTransform@2` tasks in both `continuous-deployment.yml` and `playwright-testing.yml` have been updated. Specifically, the `xmlTransformationRules` input has been removed and replaced with `enableXmlTransform: false`. This change indicates that XML transformation rules are no longer being used, and XML transformation is explicitly disabled.
Updated the `FileTransform@2` tasks in `continuous-deployment.yml` and `playwright-testing.yml` to include the `xmlTransformationRules` input with an empty string value. This ensures that no XML transformation rules are applied during the file transformation process.
Added an alert statement in the isValidDeltaDateSelected method of the EssTypesComponent class to display the targetDate for debugging purposes.
- Add alert to display selectedDate value. - Convert selectedDate to ISO string and extract date part. - Adjust targetDate to ignore BST by setting time to midnight. - Update targetDate to match current time's hours, minutes, seconds, and milliseconds.
Ensure targetDate is created using only the date part of selectedDate to avoid time zone issues, specifically British Summer Time (BST). This is done by converting selectedDate to an ISO string and splitting it to get only the date part before creating targetDate.
Improved the `isValidDeltaDateSelected` method by refining the comparison between the selected date and the current date. Simplified the creation of `targetDate` and adjusted it to match the current date's time components. Removed and added `alert` statements for better debugging and clarity. The core condition to check if the difference in days is greater than 27 or if the target date is in the future remains unchanged.
The code now initializes `targetDate` to the current date and then sets its year, month, and date to match the `selectedDate`, ensuring that the time components (hours, minutes, seconds, milliseconds) remain the same as the current date.
Enhanced alert messages by adding colons and spaces for better readability. Added a new alert to display the timezone offset of the `targetDate`.
Modified the calculation of `differenceMs` to include the timezone offset of `targetDate`. The offset is converted from minutes to milliseconds and added to the absolute difference between `targetDate` and `currentDate` to ensure accurate `differenceDays` calculation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
FileTransform@2tasks in bothcontinuous-deployment.ymlandplaywright-testing.ymlhave been updated. Specifically, thexmlTransformationRulesinput has been removed and replaced withenableXmlTransform: false. This change indicates that XML transformation rules are no longer being used, and XML transformation is explicitly disabled.