-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metric spaces #1162
Metric spaces #1162
Conversation
src/metric-spaces/pointwise-continuity-functions-metric-spaces.lagda.md
Outdated
Show resolved
Hide resolved
src/metric-spaces/uniform-continuity-functions-metric-spaces.lagda.md
Outdated
Show resolved
Hide resolved
src/metric-spaces/uniform-continuity-functions-metric-spaces.lagda.md
Outdated
Show resolved
Hide resolved
src/metric-spaces/pointwise-continuity-functions-metric-spaces.lagda.md
Outdated
Show resolved
Hide resolved
I realized I hadn't been entirely clear in what I meant, so I figured it would be easier to just implement what I meant myself. |
I'm starting to think it's not a good concept at all (at least for this module), and that we should only consider neighborhood relations that are reflexive, monotonic families reflexivity and monotonicity are the basic properties that fit the distance/neighborhood interpretation:
Reflexivity is used for almost all interesting properties of "premetrics", and gives a minimal notion of coherence between the neighborhood structure to the carrier type (making it a real structure more than just a "decorator"). Monotonicity is also used a lot; and adding it kind of justifies the use of Then |
And I wonder if we should include "symmetry" in the definition of neighborhood relation too. It's also useful for many interesting properties, and, as mentioned before, there's a canonical "symmetrization" of a neighborhood relation, characterized as the minimal symmetric neighborhood relation coarser that it (just define It looks like you can actually do something similar with reflexivity (define |
non-reflexive or non-monotonic families of relations are probably interesting too, but maybe not in the |
Hmm, does Auke not prove anything useful/interesting about premetrics in his thesis? |
Sounds like you like filters :) |
This sounds like a good argument for disregarding premetrics, yes. You could provide a series of modules that, given a neighborhood relation in the end give the universal pseudometric, and then after that always operate with pseudometrics. EDIT: This depends a bit on whether the theory has applications to things that don't satisfy all of these properties, though. |
I'm a bit hesitant to agree with this suggestion. "Pseudometric" seems to be pretty widely used. And "premetric" is at times used for weaker concepts than pseudometrics evidently. |
Ok, I probably went too far. So maybe nothing could be called a premetric space for now, since there's no real consensus on what it should mean? |
It's mostly about real numbers, so the standard premetrics on
but I'm not sure what to make of it. |
it's also related to what Martín Escardó calls I don't know if it can help us. Like maybe I should write things on |
and here: https://www.researchgate.net/publication/343732184_Completion_of_premetric_spaces/fulltext/5f3c92fc92851cd302037f27/Completion-of-premetric-spaces.pdf they call premetric space what I call a saturated metric space, which doesn't really help neither. |
and, BTW, they also call our isometries, isometric embeddings and reserve the term isometry for isometric equivalences. Should we rename our isometries, |
At that point I don't see why you wouldn't use some other even more general concept like filters instead of "metrics" in a generalized sense. You have to decide what your fundament for study is at some point. Unless you give a good reason why you want to generalize the concept right now, I don't see a reason to do this. |
I think we can safely establish that "premetric" is both a bad term and an overloaded one. Again, we should conclude that we shouldn't use the term |
You're talking about a paper with 0 citations. I see no reason to make an effort to make our terminology cohere with theirs |
I just wanted to get this PR merged with a simple naming change for premetrics. I don't understand why we have to reconsider the basis of the contribution so late in the review process |
I'm really sorry. I think I got some last-minute doubts about my contribution. As I said some other times, I don't wan't to contaminate the library with some bad concepts, abstractions, etc. We'll fix these name problems and get it merged.
have you started working on new names for |
I'll definitely give it some thoughts but I won't include anything more in this PR. |
Hi! I just had a quick glance at your pull request, in particular at the file about premetric structures. Let me note that:
Thank you so much for this huge contribution, and for all your time and effort that went into this. This is a very worthwhile pull request that opens a new direction of formalization for agda-unimath. If you are happy with it, let's merge it. Thanks also to @fredrik-bakke for his extensive reviewing! |
I don't see anything wrong with these names. But I also agree with Egbert that it is time to merge this PR - sooner rather than later. |
To my understanding we all agree there should be a better name for this concept. As Francois points out, the cited article uses "premetric" to mean something else |
I also concur with Egbert that this is a contribution of very high quality that will indeed improve the overall quality of the library. |
Thanks a lot for your kind comments.
I think I mixed-up some comments and, for some moment, I thought you had also started to implement this new name scheme (your comment was actually about isometry/isometric). If you are ok with it, we can merge it as it is now, and open a new issue where we could discuss better names. |
Very good! Since every conversation has been resolved, let's merge this PR. Further changes can be considered in a subsequent PR. Thanks again for this huge contribution! |
This PR introduces the concept of metric spaces.
We introduce a new module
metric-spaces
with the following submodules:Premetric spaces
premetric-structures
: premetric structures on a type and basic properties;reflexive-premetric-structures
;symmetric-premetric-structures
;monotonic-premetric-structures
: premetrics with upper-stable neighborhoods;triangular-premetric-structures
: premetrics that satisfy a triangular inequality;extensional-premetric-structures
: premetrics here indistinguishability characterizes equality;closed-premetric-structures
: premetrics with closed neighborhoods;discrete-premetric-structures
: premetric structure defined by mere equality;induced-premetric-structures-on-preimages
: premetric induced on the domain of a map by a premetric on its codomain;ordering-premetric-structures
: a partial ordering on the premetric structures on a type;premetric-spaces
: types equipped with a premetric structure;short-functions-premetric-spaces
: functions between premetric spaces that preserve neighborhoods;isometries-premetric-spaces
: functions between premetric spaces that identify neighborhoods;equality-of-premetric-spaces
: identity principle for the type of premetric spaces;invertible-isometries-premetric-spaces
: another characterization of equality of premetric spaces;isometric-equivalences-premetric-spaces
: another characterization of equality of premetric spaces;cauchy-approximations-premetric-spaces
: the type of Cauchy approximations in a premetric space;limits-of-cauchy-approximations-in-premetric-spaces
;Pseudometric spaces
pseudometric-structures
: reflexive, symmetric, and triangular premetrics;pseudometric-spaces
: types equipped with a pseudometric structure;Metric spaces
metric-structures
: reflexive, symmetric, triangular, and local premetrics;metric-spaces
: types equipped with a metric structure;saturated-metric-spaces
: metric spaces with closed premetrics;subspaces-metric-spaces
: metric structure induced on subsets of metric spaces;dependent-products-metric-spaces
: metric structure on dependent families of metric spaces;functions-metric-spaces
: functions between carrier types of metric spaces;short-functions-metric-spaces
: short functions between the underlying premetric spaces of metric spaces;isometries-metric-spaces
: isometries between the underlying premetric spaces of metric spaces;equality-of-metric-spaces
: identity principle in the type of metric spaces;cauchy-approximations-metric-spaces
: the type of Cauchy approximations in a metric space;convergent-cauchy-approximations-metric-spaces
: the type of convergent Cauchy approximations in a metric space;complete-metric-spaces
: the type of metric spaces where all Cauchy approximations are convergent;Example of metric spaces
metric-space-of-cauchy-approximations-in-a-metric-space
;metric-space-of-convergent-cauchy-approximations-in-a-metric-space
;metric-space-of-rational-numbers
;metric-space-of-rational-numbers-with-open-neighborhoods
;Categories of metric spaces and functors between them
precategory-of-metric-spaces-and-functions
;precategory-of-metric-spaces-and-isometries
;precategory-of-metric-spaces-and-short-functions
;category-of-metric-spaces-and-isometries
;category-of-metric-spaces-and-short-functions
;functor-category-set-functions-isometry-metric-spaces
;functor-category-short-isometry-metric-spaces
.We also introduce the standard metric structure on the real numbers in
real-numbers.metric-space-of-real-numbers
and a few miscellaneous lemmas inelementary-number-theory
andfoundation
.