Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Blank page when navigating from the tokens page #305

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nashidahmed
Copy link

@nashidahmed nashidahmed commented Jan 5, 2024

This PR fixes the following issue.

Issue

When the user navigates to a specific token (Eg. Ether) from the tokens page, the url shows 'tokens' twice. While on the default network (Ethereum) it still displays the token page for the token, on a different network (Eg. Optimism), a blank page is shown to the user.

Steps to reproduce

  1. Change the network from Ethereum to any other network (Eg. Optimism)
  2. Go to the tokens page
  3. Click on a token to view the token details (Eg. Wrapped Ether)
  4. A blank page is shown to the user.

The below screenshot is when navigating to a specific token on the Ethereum network from tokens page (The url shows 'tokens' twice but still displays the token details)

Ethereum network token page screenshot

The below screenshot is when navigating from tokens page on other networks (The page breaks and a blank page is shown)

Optimism network token page screenshot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant