Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pre-commit action failures: switch to ruby/setup-ruby #6063

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Fix pre-commit action failures: switch to ruby/setup-ruby #6063

merged 1 commit into from
Mar 4, 2024

Conversation

alex-mccarthy-unity
Copy link
Collaborator

@alex-mccarthy-unity alex-mccarthy-unity commented Mar 4, 2024

Proposed change(s)

Fixes pre-commit errors of the form:

Run actions/setup-ruby@v1
  with:
    ruby-version: 2.6
  env:
    pythonLocation: /opt/hostedtoolcache/Python/3.10.13/x64
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.10.13/x64/lib
    ImageOS: ubuntu20
------------------------
NOTE: This action is deprecated and is no longer maintained.
Please, migrate to https://github.com/ruby/setup-ruby, which is being actively maintained.
------------------------
Error: Version 2.6 not found

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Failed run before: https://github.com/Unity-Technologies/ml-agents/actions/runs/8141034251/job/22247444613?pr=6062
Successful run after: https://github.com/Unity-Technologies/ml-agents/actions/runs/8141124283/job/22247720005?pr=6063

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe) Fix pre-commit error

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

Fixes pre-commit errors of the form:
```
Run actions/setup-ruby@v1
  with:
    ruby-version: 2.6
  env:
    pythonLocation: /opt/hostedtoolcache/Python/3.10.13/x64
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.10.13/x64/lib
    ImageOS: ubuntu20
------------------------
NOTE: This action is deprecated and is no longer maintained.
Please, migrate to https://github.com/ruby/setup-ruby, which is being actively maintained.
------------------------
Error: Version 2.6 not found
```

While we're upgrading this pre-commit, also upgrade from ruby 2.6 to ruby 2.7.
Copy link
Collaborator

@miguelalonsojr miguelalonsojr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alex-mccarthy-unity alex-mccarthy-unity merged commit 86a3a6e into Unity-Technologies:develop Mar 4, 2024
4 checks passed
@alex-mccarthy-unity alex-mccarthy-unity deleted the upgrade-pre-commit-ruby branch March 4, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants