feat: client identification headers #103
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwasniew
commented
Jan 22, 2025
| @@ -44,8 +44,11 @@ data class UnleashConfig( | |||
| "Authorization" to auth, | |||
| "Content-Type" to "application/json", | |||
| "UNLEASH-APPNAME" to appName, | |||
There was a problem hiding this comment.
will be deprecated after expand/contract period
kwasniew
commented
Jan 22, 2025
| "User-Agent" to appName, | ||
| "UNLEASH-INSTANCEID" to instanceId, | ||
| "X-UNLEASH-CONNECTION-ID" to instanceId, | ||
| "X-UNLEASH-SDK" to "unleash-client-android:development", |
There was a problem hiding this comment.
we need to find a way to get current version instead of development
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
This PR adds standardised client identification headers to the feature and metrics calls that the client makes to Unleash. The headers are:
x-unleash-appname: the name of the application that is using the client.x-unleash-connection-id: a unique identifier for the current instance of the client generated by the built-in UUID libx-unleash-sdk: sdk information in the formatunleash-client-android:<version>All the headers are intended for the Unleash team so clients should not be affected.
The main use cases we have are:
Important files
Discussion points