feat(java): expose list_known_features #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sighphyre
commented
Jan 10, 2025
| @Test | ||
| public void testClientSpec() throws Exception { | ||
| ObjectMapper objectMapper = new ObjectMapper(); | ||
| objectMapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false); | ||
| File basePath = Paths.get("../client-specification/specifications").toFile(); | ||
| File indexFile = new File(basePath, "index.json"); | ||
| List<String> testSuites = | ||
| objectMapper.readValue(indexFile, new TypeReference<List<String>>() {}); | ||
| List<String> testSuites = objectMapper.readValue(indexFile, new TypeReference<List<String>>() { |
There was a problem hiding this comment.
This line and everything below is formatter, sorry
chriswk
approved these changes
Jan 14, 2025
| return name; | ||
| } | ||
|
|
||
| public Optional<String> getType() { |
There was a problem hiding this comment.
Why an optional when your constructor takes a string?
There was a problem hiding this comment.
So I'd like the constructor to take an Optional too but apparently Jackson hates that so I figured me wanting that was wrong for some reason.
| @Test | ||
| public void testClientSpec() throws Exception { | ||
| ObjectMapper objectMapper = new ObjectMapper(); | ||
| objectMapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false); | ||
| File basePath = Paths.get("../client-specification/specifications").toFile(); | ||
| File indexFile = new File(basePath, "index.json"); | ||
| List<String> testSuites = | ||
| objectMapper.readValue(indexFile, new TypeReference<List<String>>() {}); | ||
| List<String> testSuites = objectMapper.readValue(indexFile, new TypeReference<List<String>>() { |
…ods can be exposed and do memory management that should work on Java 18 and above (#198) * refactor(java): rework java engine so that static methods can be exposed cleanly * feat(java): expose core version in java engine layer (#199) * fix(java): force native encoding to utf-8 so windows doesn't set it to something horrible (#200)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes list_known_features in the Java layer so we can start to swap out
MoreOperationsin the Java SDK