Do not save capture rate in db

[TurtIeSocks]

Removes capture rate from the db, since it's entirely useless. Still sends in webhooks though.

Based off of #65 , merge that one first

[Fabio1988]

Why useless? Not used in ReactMap? Which impact on storing that information?

[Mygod]

These rates differ by account (catch badges). See also: WatWowMap/Chuck#29

[TurtIeSocks]

ReactMap does not use this info, due to it being inaccurate for everyone.

[jfberry]

Will need rebasing

[TurtIeSocks]

Should we also drop the columns and webhook data?

[Fabio1988]

As I can think of only Poracle uses it. somebody could reference it in the DTS

https://github.com/KartulUdus/PoracleJS/blob/develop/src/controllers/monster.js#L215

[Mygod]

#65 already stopped processing the rates btw. 😝

[jfberry]

It's right the data parser doesn't record them; the question is whether we should include them in webhooks by calculation magic (or someone should provide a PR to poracle)

[TurtIeSocks]

It's right the data parser doesn't record them; the question is whether we should include them in webhooks by calculation magic (or someone should provide a PR to poracle)

As in each user would save their gym badges to the poracle table to do calculations?

[jfberry]

It's right the data parser doesn't record them; the question is whether we should include them in webhooks by calculation magic (or someone should provide a PR to poracle)

As in each user would save their gym badges to the poracle table to do calculations?

I meant base rates

[Mygod]

*Catch badges, not gym badges. :)

[ccev]

I think it would be on the frontend to calculate base rates. it's as if we were to store pokemon types, names, movesets, etc. it's not on Golbat to save this.

[Fabio1988]

So for providing the catch rates in front-end we need at least the cpMultiplier, that's part of the pokemon proto. So we would need a possibility to gather that information for every mon

is the base cpMultiplier in gamemaster available @TurtIeSocks ?

[TurtIeSocks]

So for providing the catch rates in front-end we need at least the cpMultiplier, that's part of the pokemon proto. So we would need a possibility to gather that information for every mon

is the base cpMultiplier in gamemaster available @TurtIeSocks ?

I don't believe so. But the jsons are available in many places

[Fabio1988]

already done in #74
can we create an issue to not forget this?

[ccev]

I'm not really sure why you'd need CPMs from the gamemaster. to calculate a catch rate, you need

• the Pokemon's CPM (provided by Golbat)
• the Pokemon's base capture rate (provided by the gamemaster, in the Mon's pokemon settings)
• certain modifiers (balls, berries, medals, etc) (hardcoded values in the game's backend, can be found on the internet)

[Fabio1988]

I'm not really sure why you'd need CPMs from the gamemaster. to calculate a catch rate, you need

* the Pokemon's CPM (provided by Golbat)

* the Pokemon's base capture rate (provided by the gamemaster, in the Mon's pokemon settings)

* certain modifiers (balls, berries, medals, etc) (hardcoded values in the game's backend, can be found on the internet)

CPM=cpMultiplier ?
yeah it's in golbat, but it varies on the worker, true? if a worker achieves normal catch medal this will be different, no?
#79 we should continue discussion in that gh issue :)

[ccev]

No, the CPM (yes, CP multiplier) is a 1:1 mapping to the level. each pokemon level has one specific CPM assigned to it. this is then used to calculate CP and catch rates

[Fabio1988]

so yes, then golbat should store it or send in webhook... that's not done yet, we ignore that field now as we don't process capture rates anymore.