Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YDA-6125: update SRAM logo parameter #510

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

stsnel
Copy link
Member

@stsnel stsnel commented Jan 10, 2025

Update the SRAM logo parameter to use a BASE64 encoded image rather than a URL. This is needed because of a breaking change in the SRAM API: SURFscz/SBS#1604

See https://sram.surf.nl/apidocs/#/Organisation/post_api_collaborations_v1 for information on the current version of the API.

@stsnel stsnel marked this pull request as ready for review January 10, 2025 08:48
@lwesterhof lwesterhof self-requested a review January 13, 2025 08:28
Update the SRAM logo parameter to use a BASE64 encoded image rather
than a URL. This is needed because of a breaking change in the SRAM
API: SURFscz/SBS#1604

See https://sram.surf.nl/apidocs/#/Organisation/post_api_collaborations_v1
for information on the current version of the API.
@stsnel stsnel force-pushed the yda-6125-update-sram-logo-parameter branch from fd2aa21 to ab35af2 Compare January 17, 2025 14:29
Copy link
Member

@lwesterhof lwesterhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stsnel stsnel merged commit e79eaad into development Jan 17, 2025
2 checks passed
@stsnel stsnel deleted the yda-6125-update-sram-logo-parameter branch January 17, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants