fix(CustomSelect,ChipsSelect): disabled with screen readers #3876
BlackySoulpull_request_packages.yml
on: pull_request
Detect what files changed
8s
Call reusable workflow
/
Run unit tests
1m 55s
Run linters
1m 26s
Matrix: Call reusable workflow / test_e2e
Upload docs dist artifact (styleguide)
1m 53s
Upload docs dist artifact (storybook)
1m 5s
Analyze bundle size
2m 2s
Report unit test results
3s
Call reusable workflow
/
Download PR workflow payload artifact
0s
Call reusable workflow
/
Upload PR workflow payload artifact
4s
Annotations
23 errors, 2 warnings, and 10 notices
|
Call reusable workflow / Run unit tests
Process completed with exit code 1.
|
|
CustomSelect > is controlled by the keyboard:
packages/vkui/src/components/CustomSelect/CustomSelect.test.tsx#L1
Error: expect(received).toEqual(expected) // deep equality
Expected: "Bob"
Received: "Josh"
at Object.toEqual (/home/runner/work/VKUI/VKUI/packages/vkui/src/components/CustomSelect/CustomSelect.test.tsx:506:36)
at Generator.next (<anonymous>)
at asyncGeneratorStep (/home/runner/work/VKUI/VKUI/node_modules/@swc/helpers/cjs/_async_to_generator.cjs:5:28)
at _next (/home/runner/work/VKUI/VKUI/node_modules/@swc/helpers/cjs/_async_to_generator.cjs:23:17)
|
|
ChipsSelect > should ignore disabled option:
packages/vkui/src/components/ChipsSelect/ChipsSelect.test.tsx#L1
Error: expect(element).toHaveAttribute("data-hovered", "true") // element.getAttribute("data-hovered") === "true"
Expected the element to have attribute:
data-hovered="true"
Received:
data-hovered="false"
at Object.toHaveAttribute (/home/runner/work/VKUI/VKUI/packages/vkui/src/components/ChipsSelect/ChipsSelect.test.tsx:437:32)
at Generator.next (<anonymous>)
at asyncGeneratorStep (/home/runner/work/VKUI/VKUI/node_modules/@swc/helpers/cjs/_async_to_generator.cjs:5:28)
at _next (/home/runner/work/VKUI/VKUI/node_modules/@swc/helpers/cjs/_async_to_generator.cjs:23:17)
|
|
[android (chromium) • dark] › components/CustomSelectOption/CustomSelectOption.e2e.tsx:9:5 › CustomSelectOption:
packages/vkui/src/testing/e2e/index.playwright.ts#L58
1) [android (chromium) • dark] › components/CustomSelectOption/CustomSelectOption.e2e.tsx:9:5 › CustomSelectOption
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: Screenshot comparison failed:
12754 pixels (ratio 0.04 of all image pixels) are different.
Expected: /__w/VKUI/VKUI/packages/vkui/src/components/CustomSelectOption/__image_snapshots__/customselectoption-android-chromium-dark-1-snap.png
Received: /__w/VKUI/VKUI/packages/vkui/__diff_output__/components-CustomSelectOption-CustomSelectOption.e2e.tsx-CustomSelectOption-android-chromium-•-dark-retry1/customselectoption-android-chromium-dark-1-snap-actual.png
Diff: /__w/VKUI/VKUI/packages/vkui/__diff_output__/components-CustomSelectOption-CustomSelectOption.e2e.tsx-CustomSelectOption-android-chromium-•-dark-retry1/customselectoption-android-chromium-dark-1-snap-diff.png
at testing/e2e/index.playwright.ts:58
56 | expectCallCount,
57 | );
> 58 | expect(await screenshotWithClipToContent(page, options, browserName)).toMatchSnapshot(
| ^
59 | customScreenshotName,
60 | toMatchSnapshot,
61 | );
at result (/__w/VKUI/VKUI/packages/vkui/src/testing/e2e/index.playwright.ts:58:77)
at /__w/VKUI/VKUI/packages/vkui/src/components/CustomSelectOption/CustomSelectOption.e2e.tsx:15:3
|
|
Call reusable workflow / Run e2e tests for (shard 6/10)
Process completed with exit code 1.
|
|
[android (chromium) • light] › components/CustomSelectOption/CustomSelectOption.e2e.tsx:9:5 › CustomSelectOption:
packages/vkui/src/testing/e2e/index.playwright.ts#L58
1) [android (chromium) • light] › components/CustomSelectOption/CustomSelectOption.e2e.tsx:9:5 › CustomSelectOption
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: Screenshot comparison failed:
12771 pixels (ratio 0.04 of all image pixels) are different.
Expected: /__w/VKUI/VKUI/packages/vkui/src/components/CustomSelectOption/__image_snapshots__/customselectoption-android-chromium-light-1-snap.png
Received: /__w/VKUI/VKUI/packages/vkui/__diff_output__/components-CustomSelectOption-CustomSelectOption.e2e.tsx-CustomSelectOption-android-chromium-•-light-retry1/customselectoption-android-chromium-light-1-snap-actual.png
Diff: /__w/VKUI/VKUI/packages/vkui/__diff_output__/components-CustomSelectOption-CustomSelectOption.e2e.tsx-CustomSelectOption-android-chromium-•-light-retry1/customselectoption-android-chromium-light-1-snap-diff.png
at testing/e2e/index.playwright.ts:58
56 | expectCallCount,
57 | );
> 58 | expect(await screenshotWithClipToContent(page, options, browserName)).toMatchSnapshot(
| ^
59 | customScreenshotName,
60 | toMatchSnapshot,
61 | );
at result (/__w/VKUI/VKUI/packages/vkui/src/testing/e2e/index.playwright.ts:58:77)
at /__w/VKUI/VKUI/packages/vkui/src/components/CustomSelectOption/CustomSelectOption.e2e.tsx:15:3
|
|
Call reusable workflow / Run e2e tests for (shard 1/10)
Process completed with exit code 1.
|
|
[vkcom (chromium) • dark] › components/CustomSelectOption/CustomSelectOption.e2e.tsx:9:5 › CustomSelectOption:
packages/vkui/src/testing/e2e/index.playwright.ts#L58
1) [vkcom (chromium) • dark] › components/CustomSelectOption/CustomSelectOption.e2e.tsx:9:5 › CustomSelectOption
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: Screenshot comparison failed:
38406 pixels (ratio 0.06 of all image pixels) are different.
Expected: /__w/VKUI/VKUI/packages/vkui/src/components/CustomSelectOption/__image_snapshots__/customselectoption-vkcom-chromium-dark-1-snap.png
Received: /__w/VKUI/VKUI/packages/vkui/__diff_output__/components-CustomSelectOption-CustomSelectOption.e2e.tsx-CustomSelectOption-vkcom-chromium-•-dark-retry1/customselectoption-vkcom-chromium-dark-1-snap-actual.png
Diff: /__w/VKUI/VKUI/packages/vkui/__diff_output__/components-CustomSelectOption-CustomSelectOption.e2e.tsx-CustomSelectOption-vkcom-chromium-•-dark-retry1/customselectoption-vkcom-chromium-dark-1-snap-diff.png
at testing/e2e/index.playwright.ts:58
56 | expectCallCount,
57 | );
> 58 | expect(await screenshotWithClipToContent(page, options, browserName)).toMatchSnapshot(
| ^
59 | customScreenshotName,
60 | toMatchSnapshot,
61 | );
at result (/__w/VKUI/VKUI/packages/vkui/src/testing/e2e/index.playwright.ts:58:77)
at /__w/VKUI/VKUI/packages/vkui/src/components/CustomSelectOption/CustomSelectOption.e2e.tsx:15:3
|
|
Call reusable workflow / Run e2e tests for (shard 8/10)
Process completed with exit code 1.
|
|
[vkcom (firefox) • light] › components/CustomSelectOption/CustomSelectOption.e2e.tsx:9:5 › CustomSelectOption:
packages/vkui/src/testing/e2e/index.playwright.ts#L58
1) [vkcom (firefox) • light] › components/CustomSelectOption/CustomSelectOption.e2e.tsx:9:5 › CustomSelectOption
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: Screenshot comparison failed:
38710 pixels (ratio 0.06 of all image pixels) are different.
Expected: /__w/VKUI/VKUI/packages/vkui/src/components/CustomSelectOption/__image_snapshots__/customselectoption-vkcom-firefox-light-1-snap.png
Received: /__w/VKUI/VKUI/packages/vkui/__diff_output__/components-CustomSelectOption-CustomSelectOption.e2e.tsx-CustomSelectOption-vkcom-firefox-•-light-retry1/customselectoption-vkcom-firefox-light-1-snap-actual.png
Diff: /__w/VKUI/VKUI/packages/vkui/__diff_output__/components-CustomSelectOption-CustomSelectOption.e2e.tsx-CustomSelectOption-vkcom-firefox-•-light-retry1/customselectoption-vkcom-firefox-light-1-snap-diff.png
at testing/e2e/index.playwright.ts:58
56 | expectCallCount,
57 | );
> 58 | expect(await screenshotWithClipToContent(page, options, browserName)).toMatchSnapshot(
| ^
59 | customScreenshotName,
60 | toMatchSnapshot,
61 | );
at result (/__w/VKUI/VKUI/packages/vkui/src/testing/e2e/index.playwright.ts:58:77)
at /__w/VKUI/VKUI/packages/vkui/src/components/CustomSelectOption/CustomSelectOption.e2e.tsx:15:3
|
|
Call reusable workflow / Run e2e tests for (shard 4/10)
Process completed with exit code 1.
|
|
[vkcom (chromium) • light] › components/CustomSelectOption/CustomSelectOption.e2e.tsx:9:5 › CustomSelectOption:
packages/vkui/src/testing/e2e/index.playwright.ts#L58
1) [vkcom (chromium) • light] › components/CustomSelectOption/CustomSelectOption.e2e.tsx:9:5 › CustomSelectOption
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: Screenshot comparison failed:
38423 pixels (ratio 0.06 of all image pixels) are different.
Expected: /__w/VKUI/VKUI/packages/vkui/src/components/CustomSelectOption/__image_snapshots__/customselectoption-vkcom-chromium-light-1-snap.png
Received: /__w/VKUI/VKUI/packages/vkui/__diff_output__/components-CustomSelectOption-CustomSelectOption.e2e.tsx-CustomSelectOption-vkcom-chromium-•-light-retry1/customselectoption-vkcom-chromium-light-1-snap-actual.png
Diff: /__w/VKUI/VKUI/packages/vkui/__diff_output__/components-CustomSelectOption-CustomSelectOption.e2e.tsx-CustomSelectOption-vkcom-chromium-•-light-retry1/customselectoption-vkcom-chromium-light-1-snap-diff.png
at testing/e2e/index.playwright.ts:58
56 | expectCallCount,
57 | );
> 58 | expect(await screenshotWithClipToContent(page, options, browserName)).toMatchSnapshot(
| ^
59 | customScreenshotName,
60 | toMatchSnapshot,
61 | );
at result (/__w/VKUI/VKUI/packages/vkui/src/testing/e2e/index.playwright.ts:58:77)
at /__w/VKUI/VKUI/packages/vkui/src/components/CustomSelectOption/CustomSelectOption.e2e.tsx:15:3
|
|
Call reusable workflow / Run e2e tests for (shard 3/10)
Process completed with exit code 1.
|
|
[vkcom (firefox) • dark] › components/CustomSelectOption/CustomSelectOption.e2e.tsx:9:5 › CustomSelectOption:
packages/vkui/src/testing/e2e/index.playwright.ts#L58
1) [vkcom (firefox) • dark] › components/CustomSelectOption/CustomSelectOption.e2e.tsx:9:5 › CustomSelectOption
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: Screenshot comparison failed:
38719 pixels (ratio 0.06 of all image pixels) are different.
Expected: /__w/VKUI/VKUI/packages/vkui/src/components/CustomSelectOption/__image_snapshots__/customselectoption-vkcom-firefox-dark-1-snap.png
Received: /__w/VKUI/VKUI/packages/vkui/__diff_output__/components-CustomSelectOption-CustomSelectOption.e2e.tsx-CustomSelectOption-vkcom-firefox-•-dark-retry1/customselectoption-vkcom-firefox-dark-1-snap-actual.png
Diff: /__w/VKUI/VKUI/packages/vkui/__diff_output__/components-CustomSelectOption-CustomSelectOption.e2e.tsx-CustomSelectOption-vkcom-firefox-•-dark-retry1/customselectoption-vkcom-firefox-dark-1-snap-diff.png
at testing/e2e/index.playwright.ts:58
56 | expectCallCount,
57 | );
> 58 | expect(await screenshotWithClipToContent(page, options, browserName)).toMatchSnapshot(
| ^
59 | customScreenshotName,
60 | toMatchSnapshot,
61 | );
at result (/__w/VKUI/VKUI/packages/vkui/src/testing/e2e/index.playwright.ts:58:77)
at /__w/VKUI/VKUI/packages/vkui/src/components/CustomSelectOption/CustomSelectOption.e2e.tsx:15:3
|
|
Call reusable workflow / Run e2e tests for (shard 9/10)
Process completed with exit code 1.
|
|
[ios (webkit) • dark] › components/CustomSelectOption/CustomSelectOption.e2e.tsx:9:5 › CustomSelectOption:
packages/vkui/src/testing/e2e/index.playwright.ts#L58
1) [ios (webkit) • dark] › components/CustomSelectOption/CustomSelectOption.e2e.tsx:9:5 › CustomSelectOption
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: Screenshot comparison failed:
12757 pixels (ratio 0.04 of all image pixels) are different.
Expected: /__w/VKUI/VKUI/packages/vkui/src/components/CustomSelectOption/__image_snapshots__/customselectoption-ios-webkit-dark-1-snap.png
Received: /__w/VKUI/VKUI/packages/vkui/__diff_output__/components-CustomSelectOption-CustomSelectOption.e2e.tsx-CustomSelectOption-ios-webkit-•-dark-retry1/customselectoption-ios-webkit-dark-1-snap-actual.png
Diff: /__w/VKUI/VKUI/packages/vkui/__diff_output__/components-CustomSelectOption-CustomSelectOption.e2e.tsx-CustomSelectOption-ios-webkit-•-dark-retry1/customselectoption-ios-webkit-dark-1-snap-diff.png
at testing/e2e/index.playwright.ts:58
56 | expectCallCount,
57 | );
> 58 | expect(await screenshotWithClipToContent(page, options, browserName)).toMatchSnapshot(
| ^
59 | customScreenshotName,
60 | toMatchSnapshot,
61 | );
at result (/__w/VKUI/VKUI/packages/vkui/src/testing/e2e/index.playwright.ts:58:77)
at /__w/VKUI/VKUI/packages/vkui/src/components/CustomSelectOption/CustomSelectOption.e2e.tsx:15:3
|
|
Call reusable workflow / Run e2e tests for (shard 7/10)
Process completed with exit code 1.
|
|
[vkcom (webkit) • dark] › components/CustomSelectOption/CustomSelectOption.e2e.tsx:9:5 › CustomSelectOption:
packages/vkui/src/testing/e2e/index.playwright.ts#L58
1) [vkcom (webkit) • dark] › components/CustomSelectOption/CustomSelectOption.e2e.tsx:9:5 › CustomSelectOption
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: Screenshot comparison failed:
38409 pixels (ratio 0.06 of all image pixels) are different.
Expected: /__w/VKUI/VKUI/packages/vkui/src/components/CustomSelectOption/__image_snapshots__/customselectoption-vkcom-webkit-dark-1-snap.png
Received: /__w/VKUI/VKUI/packages/vkui/__diff_output__/components-CustomSelectOption-CustomSelectOption.e2e.tsx-CustomSelectOption-vkcom-webkit-•-dark-retry1/customselectoption-vkcom-webkit-dark-1-snap-actual.png
Diff: /__w/VKUI/VKUI/packages/vkui/__diff_output__/components-CustomSelectOption-CustomSelectOption.e2e.tsx-CustomSelectOption-vkcom-webkit-•-dark-retry1/customselectoption-vkcom-webkit-dark-1-snap-diff.png
at testing/e2e/index.playwright.ts:58
56 | expectCallCount,
57 | );
> 58 | expect(await screenshotWithClipToContent(page, options, browserName)).toMatchSnapshot(
| ^
59 | customScreenshotName,
60 | toMatchSnapshot,
61 | );
at result (/__w/VKUI/VKUI/packages/vkui/src/testing/e2e/index.playwright.ts:58:77)
at /__w/VKUI/VKUI/packages/vkui/src/components/CustomSelectOption/CustomSelectOption.e2e.tsx:15:3
|
|
Call reusable workflow / Run e2e tests for (shard 10/10)
Process completed with exit code 1.
|
|
[ios (webkit) • light] › components/CustomSelectOption/CustomSelectOption.e2e.tsx:9:5 › CustomSelectOption:
packages/vkui/src/testing/e2e/index.playwright.ts#L58
1) [ios (webkit) • light] › components/CustomSelectOption/CustomSelectOption.e2e.tsx:9:5 › CustomSelectOption
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: Screenshot comparison failed:
12762 pixels (ratio 0.04 of all image pixels) are different.
Expected: /__w/VKUI/VKUI/packages/vkui/src/components/CustomSelectOption/__image_snapshots__/customselectoption-ios-webkit-light-1-snap.png
Received: /__w/VKUI/VKUI/packages/vkui/__diff_output__/components-CustomSelectOption-CustomSelectOption.e2e.tsx-CustomSelectOption-ios-webkit-•-light-retry1/customselectoption-ios-webkit-light-1-snap-actual.png
Diff: /__w/VKUI/VKUI/packages/vkui/__diff_output__/components-CustomSelectOption-CustomSelectOption.e2e.tsx-CustomSelectOption-ios-webkit-•-light-retry1/customselectoption-ios-webkit-light-1-snap-diff.png
at testing/e2e/index.playwright.ts:58
56 | expectCallCount,
57 | );
> 58 | expect(await screenshotWithClipToContent(page, options, browserName)).toMatchSnapshot(
| ^
59 | customScreenshotName,
60 | toMatchSnapshot,
61 | );
at result (/__w/VKUI/VKUI/packages/vkui/src/testing/e2e/index.playwright.ts:58:77)
at /__w/VKUI/VKUI/packages/vkui/src/components/CustomSelectOption/CustomSelectOption.e2e.tsx:15:3
|
|
Call reusable workflow / Run e2e tests for (shard 2/10)
Process completed with exit code 1.
|
|
[vkcom (webkit) • light] › components/CustomSelectOption/CustomSelectOption.e2e.tsx:9:5 › CustomSelectOption:
packages/vkui/src/testing/e2e/index.playwright.ts#L58
1) [vkcom (webkit) • light] › components/CustomSelectOption/CustomSelectOption.e2e.tsx:9:5 › CustomSelectOption
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: Screenshot comparison failed:
38414 pixels (ratio 0.06 of all image pixels) are different.
Expected: /__w/VKUI/VKUI/packages/vkui/src/components/CustomSelectOption/__image_snapshots__/customselectoption-vkcom-webkit-light-1-snap.png
Received: /__w/VKUI/VKUI/packages/vkui/__diff_output__/components-CustomSelectOption-CustomSelectOption.e2e.tsx-CustomSelectOption-vkcom-webkit-•-light-retry1/customselectoption-vkcom-webkit-light-1-snap-actual.png
Diff: /__w/VKUI/VKUI/packages/vkui/__diff_output__/components-CustomSelectOption-CustomSelectOption.e2e.tsx-CustomSelectOption-vkcom-webkit-•-light-retry1/customselectoption-vkcom-webkit-light-1-snap-diff.png
at testing/e2e/index.playwright.ts:58
56 | expectCallCount,
57 | );
> 58 | expect(await screenshotWithClipToContent(page, options, browserName)).toMatchSnapshot(
| ^
59 | customScreenshotName,
60 | toMatchSnapshot,
61 | );
at result (/__w/VKUI/VKUI/packages/vkui/src/testing/e2e/index.playwright.ts:58:77)
at /__w/VKUI/VKUI/packages/vkui/src/components/CustomSelectOption/CustomSelectOption.e2e.tsx:15:3
|
|
Call reusable workflow / Run e2e tests for (shard 5/10)
Process completed with exit code 1.
|
|
Analyze bundle size
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: andresz1/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Analyze bundle size
The following actions uses node12 which is deprecated and will be forced to run on node16: andresz1/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
🎭 Playwright Run Summary
1 failed
[android (chromium) • dark] › components/CustomSelectOption/CustomSelectOption.e2e.tsx:9:5 › CustomSelectOption
25 skipped
85 passed (46.8s)
|
|
🎭 Playwright Run Summary
1 failed
[android (chromium) • light] › components/CustomSelectOption/CustomSelectOption.e2e.tsx:9:5 › CustomSelectOption
10 skipped
100 passed (50.4s)
|
|
🎭 Playwright Run Summary
1 failed
[vkcom (chromium) • dark] › components/CustomSelectOption/CustomSelectOption.e2e.tsx:9:5 › CustomSelectOption
28 skipped
82 passed (49.1s)
|
|
🎭 Playwright Run Summary
1 failed
[vkcom (firefox) • light] › components/CustomSelectOption/CustomSelectOption.e2e.tsx:9:5 › CustomSelectOption
20 skipped
90 passed (1.1m)
|
|
🎭 Playwright Run Summary
1 failed
[vkcom (chromium) • light] › components/CustomSelectOption/CustomSelectOption.e2e.tsx:9:5 › CustomSelectOption
20 skipped
90 passed (52.2s)
|
|
🎭 Playwright Run Summary
1 failed
[vkcom (firefox) • dark] › components/CustomSelectOption/CustomSelectOption.e2e.tsx:9:5 › CustomSelectOption
28 skipped
82 passed (57.2s)
|
|
🎭 Playwright Run Summary
1 failed
[ios (webkit) • dark] › components/CustomSelectOption/CustomSelectOption.e2e.tsx:9:5 › CustomSelectOption
26 skipped
84 passed (1.5m)
|
|
🎭 Playwright Run Summary
1 failed
[vkcom (webkit) • dark] › components/CustomSelectOption/CustomSelectOption.e2e.tsx:9:5 › CustomSelectOption
28 skipped
82 passed (1.5m)
|
|
🎭 Playwright Run Summary
1 failed
[ios (webkit) • light] › components/CustomSelectOption/CustomSelectOption.e2e.tsx:9:5 › CustomSelectOption
21 skipped
89 passed (1.5m)
|
|
🎭 Playwright Run Summary
1 failed
[vkcom (webkit) • light] › components/CustomSelectOption/CustomSelectOption.e2e.tsx:9:5 › CustomSelectOption
20 skipped
90 passed (1.6m)
|
Artifacts
Produced during runtime
| Name | Size | |
|---|---|---|
|
all-blob-reports-1-10
Expired
|
999 KB |
|
|
all-blob-reports-10-10
Expired
|
861 KB |
|
|
all-blob-reports-2-10
Expired
|
968 KB |
|
|
all-blob-reports-3-10
Expired
|
952 KB |
|
|
all-blob-reports-4-10
Expired
|
1.09 MB |
|
|
all-blob-reports-5-10
Expired
|
873 KB |
|
|
all-blob-reports-6-10
Expired
|
978 KB |
|
|
all-blob-reports-7-10
Expired
|
971 KB |
|
|
all-blob-reports-8-10
Expired
|
999 KB |
|
|
all-blob-reports-9-10
Expired
|
1.2 MB |
|
|
playwright-report
Expired
|
7.37 MB |
|
|
pr_workflow_payload
Expired
|
147 Bytes |
|
|
storybook-dist
Expired
|
3.9 MB |
|
|
styleguide-dist
Expired
|
2.12 MB |
|
|
test-output
Expired
|
467 KB |
|