Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[project-sequencer-statemachine] ResizeNoteRightStateを追加 #2477

Conversation

sigprogramming
Copy link
Contributor

内容

以下を行います。

  • ResizeNoteRightStateを追加

関連 Issue

その他

@sigprogramming sigprogramming requested a review from a team as a code owner January 5, 2025 10:29
@sigprogramming sigprogramming requested review from Hiroshiba and removed request for a team January 5, 2025 10:29
@voicevox-preview-pages
Copy link

🚀 プレビュー用ページを作成しました 🚀

更新時点でのコミットハッシュ:15ebc8a

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

ここまで一致していると、流石に共通化したほうがメリットが大きいだろうな~とちょっと思いました。
コンストラクタにrightOrLeftを受け付けて、処理が異なる部分だけ分岐する感じの実装とか!

とりあえず問題ではないと思うのでマージします!!

@Hiroshiba Hiroshiba merged commit ae7ad0a into VOICEVOX:project-sequencer-statemachine Jan 5, 2025
10 checks passed
@sigprogramming sigprogramming deleted the add_resize_note_right_state branch January 6, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants