refactor: extractVvpp周りのTODOを解決 #2499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 プレビュー用ページを作成しました 🚀 更新時点でのコミットハッシュ： |
Hiroshiba
commented
Jan 21, 2025
Comment on lines
+224
to
+229
| // https://www.garykessler.net/library/file_sigs.html#:~:text=7-zip%20compressed%20file | ||
| const SEVEN_ZIP_MAGIC_NUMBER = Buffer.from([ | ||
| 0x37, 0x7a, 0xbc, 0xaf, 0x27, 0x1c, | ||
| ]); | ||
|
|
||
| const ZIP_MAGIC_NUMBER = Buffer.from([0x50, 0x4b, 0x03, 0x04]); |
There was a problem hiding this comment.
スコープは短いほど良いので関数内に移動･･･
というよりこれは単純に場所が近いほうがわかりやすいからというのが大きそう。
| { | ||
| vvppLikeFilePath: vvppPath, | ||
| vvppEngineDir: this.vvppEngineDir, | ||
| tmpDir: app.getPath("temp"), |
There was a problem hiding this comment.
vvpppを結合したものができるファイル、やっぱりelectronのtempディレクトリに置くようにしました。
これが一番明確だなぁと。
Hiroshiba
changed the title
Hiroshiba
commented
Jan 21, 2025
There was a problem hiding this comment.
@sevenc-nanashi よかったらまたレビューを･･･！！
ちなみにメンションしなくてもReviewersへの追加だけで良かったりしますか･･･？ 👀
|
Reviewer追加でもGitHub Mobileの通知とかは来ますね。 |
|
あっなるほどです！！ |
|
レビューありがとうございます、マージします！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
で後回しにしたTODO系を片付けました。
その他