[project-sequencer-statemachine] ステートのインスタンスの作成をファクトリ関数で行うようにする #2500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigprogramming
requested review from
Hiroshiba
and removed request for
a team
|
🚀 プレビュー用ページを作成しました 🚀 更新時点でのコミットハッシュ： |
sigprogramming
commented
Jan 22, 2025
Comment on lines
87
to
107
| type PartialStore = { | ||
| state: { | ||
| tpqn: number; | ||
| sequencerSnapType: number; | ||
| sequencerEditTarget: SequencerEditTarget; | ||
| editorFrameRate: number; | ||
| }; | ||
| getters: { | ||
| SELECTED_TRACK_ID: TrackId; | ||
| SELECTED_TRACK: Track; | ||
| SELECTED_NOTE_IDS: Set<NoteId>; | ||
| }; | ||
| actions: { | ||
| SELECT_NOTES: (payload: { noteIds: NoteId[] }) => Promise<void>; | ||
| DESELECT_NOTES: (payload: { noteIds: NoteId[] }) => Promise<void>; | ||
| DESELECT_ALL_NOTES: () => Promise<void>; | ||
| PLAY_PREVIEW_SOUND: (payload: { | ||
| noteNumber: number; | ||
| duration?: number; | ||
| }) => Promise<void>; | ||
| COMMAND_ADD_NOTES: (payload: { | ||
| notes: Note[]; | ||
| trackId: TrackId; | ||
| }) => Promise<void>; | ||
| COMMAND_UPDATE_NOTES: (payload: { | ||
| notes: Note[]; | ||
| trackId: TrackId; | ||
| }) => Promise<void>; | ||
| COMMAND_SET_PITCH_EDIT_DATA: (payload: { | ||
| pitchArray: number[]; | ||
| startFrame: number; | ||
| trackId: TrackId; | ||
| }) => Promise<void>; | ||
| COMMAND_ERASE_PITCH_EDIT_DATA: (payload: { | ||
| startFrame: number; | ||
| frameLength: number; | ||
| trackId: TrackId; | ||
| }) => Promise<void>; | ||
| }; | ||
| state: Pick< | ||
| Store["state"], | ||
| "tpqn" | "sequencerSnapType" | "sequencerEditTarget" | "editorFrameRate" | ||
| >; | ||
| getters: Pick< | ||
| Store["getters"], | ||
| "SELECTED_TRACK_ID" | "SELECTED_TRACK" | "SELECTED_NOTE_IDS" | ||
| >; | ||
| actions: Pick< | ||
| Store["actions"], | ||
| | "SELECT_NOTES" | ||
| | "DESELECT_NOTES" | ||
| | "DESELECT_ALL_NOTES" | ||
| | "PLAY_PREVIEW_SOUND" | ||
| | "COMMAND_ADD_NOTES" | ||
| | "COMMAND_UPDATE_NOTES" | ||
| | "COMMAND_SET_PITCH_EDIT_DATA" | ||
| | "COMMAND_ERASE_PITCH_EDIT_DATA" | ||
| >; | ||
| }; |
There was a problem hiding this comment.
StoreからPickするようにしました。
13 tasks
Hiroshiba
reviewed
Jan 22, 2025
Hiroshiba
approved these changes
Jan 23, 2025
Hiroshiba
merged commit 2779fbe
into
VOICEVOX:project-sequencer-statemachine
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
ステートのインスタンスの作成をファクトリ関数で行うようにします。
（ステートの中で他のステートのインスタンスの作成を行わないようにします）
関連 Issue
その他