Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive citation #464

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Archive citation #464

merged 1 commit into from
Jun 24, 2024

Conversation

otokama
Copy link
Member

@otokama otokama commented May 22, 2024

Archive citation improvements

Asana Ticket: (link) (:star:)
https://app.asana.com/0/1205959349035436/1207013390694593/f

What does this Pull Request do? (:star:)

Improve "Cite this item" component using relevant metadata fields and the permalink

What's the changes? (:star:)

  • Add suggested citation and citation style guide instead of just showing a permalink

How should this be tested?

  • Go to the generated preview
  • For each archive, the suggested citation is composed using the following template:
    {Creator (if exists)}. {Title}. {Digital Repository Name (DLP Instance Name)}. {Sponsoring Institution}. {Permalink} accessed {Current date in client browser}.
  • Click "Copy Citation" and the suggested citation should copied to the clipboard

Interested parties

@goynejennifer
@whunter

@otokama otokama requested a review from goynejennifer May 22, 2024 15:47
@otokama otokama added Ready for review dependencies Pull requests that update a dependency file labels May 22, 2024
@goynejennifer
Copy link
Collaborator

Works as expected. However if the item is in the featured items, on the main page, then the code doesn't work

@otokama
Copy link
Member Author

otokama commented May 22, 2024

Works as expected. However if the item is in the featured items, on the main page, then the code doesn't work

Those items are actually hard coded to point to the production URL and the production site hasn't been updated yet. Once updated, the citation component should also show up in those featured items.

Copy link
Collaborator

@goynejennifer goynejennifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve works great!

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-464.d234tdmg9icdwk.amplifyapp.com

@whunter whunter merged commit df27dc8 into dev Jun 24, 2024
1 of 2 checks passed
@whunter whunter deleted the archive-citation branch June 24, 2024 13:41
@whunter
Copy link
Member

whunter commented Jun 24, 2024

This is awesome 🤘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants