fix bad logic in Sony LED suspend/resume path

Thanks to @flibitijibibo for pointing out the problem.
ValveSoftware · Jun 8, 2017 · 2679c9f · 2679c9f
1 parent 5e1625e
commit 2679c9f
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c
@@ -2740,8 +2740,8 @@ static int sony_suspend(struct hid_device *hdev, pm_message_t message)
 	 * On suspend save the current LED state,
 	 * stop running force-feedback and blank the LEDS.
 	 */
-	if (SONY_LED_SUPPORT || SONY_FF_SUPPORT) {
-		struct sony_sc *sc = hid_get_drvdata(hdev);
+	struct sony_sc *sc = hid_get_drvdata(hdev);
+	if (sc->quirks & (SONY_LED_SUPPORT | SONY_FF_SUPPORT)) {
 
 #ifdef CONFIG_SONY_FF
 		sc->left = sc->right = 0;
@@ -2760,8 +2760,8 @@ static int sony_suspend(struct hid_device *hdev, pm_message_t message)
 static int sony_resume(struct hid_device *hdev)
 {
 	/* Restore the state of controller LEDs on resume */
-	if (SONY_LED_SUPPORT) {
-		struct sony_sc *sc = hid_get_drvdata(hdev);
+	struct sony_sc *sc = hid_get_drvdata(hdev);
+	if (sc->quirks & SONY_LED_SUPPORT) {
 
 		memcpy(sc->led_state, sc->resume_led_state,
 			sizeof(sc->led_state));