pr stuff

VeryGoodOpenSource · Oct 30, 2023 · 1764b5b · 1764b5b
1 parent e142dae
commit 1764b5b
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 12 deletions.
diff --git a/packages/dart_frog_cli/lib/src/commands/dev/dev.dart b/packages/dart_frog_cli/lib/src/commands/dev/dev.dart
@@ -118,14 +118,13 @@ class DevCommand extends DartFrogCommand {
 
     final hostname = results['hostname'] as String?;
 
-    late final io.InternetAddress? ip;
-    if (hostname == null) {
-      ip = null;
-    } else {
+    io.InternetAddress? ip;
+    if (hostname != null) {
       ip = io.InternetAddress.tryParse(hostname);
       if (ip == null) {
-        logger.err('Invalid hostname "$hostname": must be a valid '
-            'IPv4 or IPv6 address.');
+        logger.err(
+          'Invalid hostname "$hostname": must be a valid IPv4 or IPv6 address.',
+        );
         return ExitCode.software.code;
       }
     }

diff --git a/packages/dart_frog_cli/lib/src/daemon/domain/dev_server_domain.dart b/packages/dart_frog_cli/lib/src/daemon/domain/dev_server_domain.dart
@@ -59,15 +59,12 @@ class DevServerDomain extends DomainBase {
 
     final devServerBundleGenerator = await _generator(dartFrogDevServerBundle);
 
-    late final InternetAddress? ip;
-    if (hostname == null) {
-      ip = null;
-    } else {
+    InternetAddress? ip;
+    if (hostname != null) {
       ip = InternetAddress.tryParse(hostname);
       if (ip == null) {
         throw DartFrogDaemonMalformedMessageException(
-          'invalid hostname "$hostname": must be a valid '
-          'IPv4 or IPv6 address.',
+          'invalid hostname "$hostname": must be a valid IPv4 or IPv6 address.',
         );
       }
     }

diff --git a/packages/dart_frog_cli/test/src/commands/dev/dev_test.dart b/packages/dart_frog_cli/test/src/commands/dev/dev_test.dart
@@ -223,6 +223,12 @@ void main() {
 
       await expectLater(command.run(), completion(ExitCode.software.code));
 
+      verify(
+        () => logger.err(
+          'Invalid hostname "ticarica": must be a valid IPv4 or IPv6 address.',
+        ),
+      ).called(1);
+
       verifyNever(() => runner.start());
     });