Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add prod server builder #1161

Merged
merged 6 commits into from
Nov 27, 2023
Merged

Conversation

renancaraujo
Copy link
Contributor

@renancaraujo renancaraujo commented Nov 23, 2023

Status

READY

Description

Extract the code to generate a prod server to a separate class from the command.

in the scope of #1016

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@renancaraujo renancaraujo requested a review from a team as a code owner November 23, 2023 16:20
alestiago
alestiago previously approved these changes Nov 24, 2023
Copy link
Contributor

@alestiago alestiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 !

@renancaraujo renancaraujo force-pushed the renan/add-proderver-builder branch from 005da81 to 7fda4c6 Compare November 27, 2023 13:53
@renancaraujo renancaraujo force-pushed the renan/add-proderver-builder branch from 98297ef to da80a09 Compare November 27, 2023 14:11
@renancaraujo renancaraujo merged commit 8497832 into main Nov 27, 2023
27 checks passed
@renancaraujo renancaraujo deleted the renan/add-proderver-builder branch November 27, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants