Add ruby 3.4 Support (#2189)

* add ruyb 3.4 * add changelog entry * fix spec * fix spec * fix specs for ruby-main
ViewComponent · Jan 6, 2025 · ad04301 · ad04301
1 parent c5feaed
commit ad04301
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -59,6 +59,12 @@ jobs:
           - ruby_version: "3.3"
             rails_version: "8.0"
             mode: "capture_patch_enabled"
+          - ruby_version: "3.4"
+            rails_version: "8.0"
+            mode: "capture_patch_disabled"
+          - ruby_version: "3.4"
+            rails_version: "8.0"
+            mode: "capture_patch_enabled"
           - ruby_version: "head"
             rails_version: "main"
             mode: "capture_patch_disabled"

diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md
@@ -14,6 +14,10 @@ nav_order: 5
 
     *Joel Hawksley*
 
+* Add ruby 3.4 support to CI.
+
+    *Reegan Viljoen*
+
 ## 3.21.0
 
 * Updates testing docs to include an example of how to use with RSpec.

diff --git a/test/sandbox/test/rendering_test.rb b/test/sandbox/test/rendering_test.rb
@@ -16,7 +16,7 @@ def test_render_inline_allocations
     MyComponent.ensure_compiled
 
     allocations = (Rails.version.to_f >= 8.0) ?
-      {"3.4.0" => 110, "3.3.6" => 129} :
+      {"3.5.0" => 117, "3.4.1" => 117, "3.3.6" => 129} :
       {"3.3.6" => 120, "3.3.0" => 120, "3.2.6" => 118, "3.1.6" => 118, "3.0.7" => 127}
 
     assert_allocations(**allocations) do