Attempt to fix Ferrum timeout errors #1877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkllnk
added a commit
to mkllnk/openfoodnetwork
that referenced
this pull request
Nov 2, 2023
Rails is registering a driver called `cuprite`. And when we did that as well the driver got registered three times somehow. It looked like our driver options were used in the end but just to clarify I gave it a unique name. This was inspired by: * ViewComponent/view_component#1877 It suggests that it may avoid dead browser errors on CI. We'll see.
4 tasks
claudiob
pushed a commit
to claudiob/view_component
that referenced
this pull request
Dec 22, 2023
* Attempt to fix Ferrum timeout errors * Add CHANGELOG entry; fix linting issues
claudiob
pushed a commit
to claudiob/view_component
that referenced
this pull request
Jan 3, 2024
* Attempt to fix Ferrum timeout errors * Add CHANGELOG entry; fix linting issues
fleblond07
pushed a commit
to fleblond07/openfoodnetwork
that referenced
this pull request
Mar 13, 2024
Rails is registering a driver called `cuprite`. And when we did that as well the driver got registered three times somehow. It looked like our driver options were used in the end but just to clarify I gave it a unique name. This was inspired by: * ViewComponent/view_component#1877 It suggests that it may avoid dead browser errors on CI. We'll see.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
We're seeing quite a few
Ferrum::ProcessTimeoutError: Browser did not produce websocket url within 10 secondserrors in CI jobs. I did a little digging and discovered the Cuprite driver we're registering in test_helper.rb is getting overwritten by Rails, so it's not using any of the config options we're passing in.What approach did you choose and why?
primer/view_components solved this a while ago by registering a driver with a unique name, so that's what I did here.