Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes h3 tables having partial/missing regions. #1223

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

BielStela
Copy link
Contributor

With the last datasets updates the nodata handling changed meaning that the results of raster to h3 have different cardinalities. The join supposed all dataframes equal. It failed by keeping only the indexes of the first in the list.

General description

from this:
image

to
image

Designs

Link to the related design prototypes (if applicable)

Testing instructions

Provide minimal instructions on how to test this PR.

  • Apart from the added feature / bug fix, check overall performance, styling...

Checklist before merging

  • Branch name / PR includes the related Jira ticket Id.
  • Tests to check core implementation / bug fix added.
  • All checks in Continuous Integration workflow pass.
  • Feature functionally tested by reviewer(s).
  • Code reviewed by reviewer(s).
  • Documentation updated (README, CHANGELOG...) (if required)

With the last datasets updates the nodata handling changed meaning that the results of raster to h3 have different cardinalities. The join supposed all dataframes equal. It failed by keeping only the indexes of the first in the list.
Copy link

vercel bot commented Jan 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
landgriffon-client ⬜️ Ignored (Inspect) Jan 17, 2025 3:12pm
landgriffon-cookie-traceability ⬜️ Ignored (Inspect) Jan 17, 2025 3:12pm
landgriffon-marketing ⬜️ Ignored (Inspect) Jan 17, 2025 3:12pm

@BielStela BielStela requested a review from elpamart January 17, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant