Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NumberInput component which allows to enter decimals #291

Merged
merged 8 commits into from
Nov 17, 2023
Merged

Add NumberInput component which allows to enter decimals #291

merged 8 commits into from
Nov 17, 2023

Conversation

asimonok
Copy link
Collaborator

Resovles #247

@asimonok asimonok requested a review from mikhail-vl November 16, 2023 18:15
@asimonok asimonok self-assigned this Nov 16, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 16, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (33cda97) 97.63% compared to head (f2b8f8d) 97.53%.

❗ Current head f2b8f8d differs from pull request most recent head 2aead7b. Consider uploading reports for the commit 2aead7b to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #291      +/-   ##
==========================================
- Coverage   97.63%   97.53%   -0.11%     
==========================================
  Files          59       59              
  Lines         974      972       -2     
  Branches      174      172       -2     
==========================================
- Hits          951      948       -3     
  Misses         13       13              
- Partials       10       11       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikhail-vl mikhail-vl added the enhancement New feature or request label Nov 17, 2023
@mikhail-vl mikhail-vl added this to the Version 3.3.0 milestone Nov 17, 2023
@asimonok asimonok marked this pull request as draft November 17, 2023 09:39
@asimonok asimonok marked this pull request as ready for review November 17, 2023 13:39
mikhail-vl
mikhail-vl approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mikhail-vl mikhail-vl merged commit 4378556 into main Nov 17, 2023
3 checks passed
@mikhail-vl mikhail-vl deleted the feat/fix-number-input-normalize branch November 17, 2023 18:41
@mikhail-vl mikhail-vl mentioned this pull request Nov 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikhail-vl mikhail-vl mikhail-vl approved these changes

Assignees

@asimonok asimonok

Labels
enhancement New feature or request
Projects
None yet
Milestone
Version 3.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@asimonok @mikhail-vl