Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Data Source option for reset button #296

Merged
merged 4 commits into from
Nov 21, 2023

Conversation

asimonok
Copy link
Collaborator

Resolves #248

@asimonok asimonok requested a review from a team November 21, 2023 10:29
@asimonok asimonok self-assigned this Nov 21, 2023
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7d4baad) 97.78% compared to head (a8bc4e9) 97.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #296      +/-   ##
==========================================
+ Coverage   97.78%   97.83%   +0.04%     
==========================================
  Files          64       64              
  Lines        1038     1060      +22     
  Branches      183      186       +3     
==========================================
+ Hits         1015     1037      +22     
  Misses         12       12              
  Partials       11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikhail-vl mikhail-vl added the enhancement New feature or request label Nov 21, 2023
@mikhail-vl mikhail-vl added this to the Version 3.3.0 milestone Nov 21, 2023
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mikhail-vl mikhail-vl merged commit 28e4114 into main Nov 21, 2023
6 checks passed
@mikhail-vl mikhail-vl deleted the feat/datasource-for-reset-button branch November 21, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create and Delete request compatibility
2 participants