Update Form elements #520
Merged
Update Form elements #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #520 +/- ##
=======================================
Coverage 99.18% 99.19%
=======================================
Files 116 116
Lines 1969 1982 +13
Branches 483 492 +9
=======================================
+ Hits 1953 1966 +13
Misses 14 14
Partials 2 2 ☔ View full report in Codecov by Sentry. |
asimonok
approved these changes
Oct 18, 2024
| @@ -53,13 +53,13 @@ export const CodeElement: React.FC<Props> = ({ element, onChange }) => { | |||
| language={element.language || CodeLanguage.JAVASCRIPT} | |||
| showLineNumbers={true} | |||
| showMiniMap={(element.value?.length || 0) > 100} | |||
| value={element.value || ''} | |||
| value={element.value?.replaceAll('\\n', '\n') || ''} | |||
There was a problem hiding this comment.
This feels suspicious.... why is this only needed for \n and not other escapes (such as \r, or just \ itself?)
There was a problem hiding this comment.
@asimonok Could you please comment?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #517
Resolves #516