Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update element helpers #570

Merged
merged 10 commits into from
Dec 23, 2024
Merged

Update element helpers #570

merged 10 commits into from
Dec 23, 2024

Conversation

vitPinchuk
Copy link
Contributor

Resolves: #567

@vitPinchuk vitPinchuk self-assigned this Dec 10, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.07%. Comparing base (7fbfabf) to head (e84d021).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #570   +/-   ##
=======================================
  Coverage   99.07%   99.07%           
=======================================
  Files         116      116           
  Lines        2049     2062   +13     
  Branches      530      512   -18     
=======================================
+ Hits         2030     2043   +13     
  Misses         17       17           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vitPinchuk vitPinchuk marked this pull request as draft December 10, 2024 15:30
@mikhail-vl mikhail-vl added the enhancement New feature or request label Dec 10, 2024
@mikhail-vl mikhail-vl added this to the Forms 5.0.0 milestone Dec 10, 2024
@vitPinchuk vitPinchuk requested review from asimonok and mikhail-vl and removed request for asimonok December 11, 2024 10:06
@vitPinchuk vitPinchuk marked this pull request as ready for review December 11, 2024 10:06
@vitPinchuk vitPinchuk requested a review from asimonok December 11, 2024 10:07
Copy link
Collaborator

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl ready for review

Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl mikhail-vl merged commit 48a9876 into main Dec 23, 2024
5 checks passed
@mikhail-vl mikhail-vl deleted the feat/update-element-helpers branch December 23, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Accessing Dashboard/Global Variables from Button Actions in Business Forms
3 participants