Skip to content

Commit

Permalink
updating number insight and video
Browse files Browse the repository at this point in the history
  • Loading branch information
maxkahan committed Nov 14, 2024
1 parent 72ada83 commit 6ee22e6
Show file tree
Hide file tree
Showing 8 changed files with 17 additions and 10 deletions.
4 changes: 4 additions & 0 deletions number_insight/CHANGES.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# 1.0.5
- Fix missed method renaming
- Docstring update

# 1.0.4
- Update dependency versions

Expand Down
2 changes: 1 addition & 1 deletion number_insight/src/vonage_number_insight/_version.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = '1.0.4'
__version__ = '1.0.5'
2 changes: 1 addition & 1 deletion number_insight/src/vonage_number_insight/number_insight.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def get_basic_info(self, options: BasicInsightRequest) -> BasicInsightResponse:
return BasicInsightResponse(**response)

@validate_call
def standard_number_insight(
def get_standard_info(
self, options: StandardInsightRequest
) -> StandardInsightResponse:
"""Get standard number insight information about a phone number.
Expand Down
2 changes: 1 addition & 1 deletion number_insight/src/vonage_number_insight/requests.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ class AdvancedAsyncInsightRequest(StandardInsightRequest):
Args:
number (PhoneNumber): The phone number to get insight information for.
callback (str): The URL to send the asynchronous response to.
country (str, Optional): The country code for the phone number.
cnam (bool, Optional): Whether to include the Caller ID Name (CNAM) with the response.
callback (str): The URL to send the asynchronous response to.
"""

callback: str
Expand Down
2 changes: 1 addition & 1 deletion number_insight/tests/test_number_insight.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ def test_standard_insight():
'standard_insight.json',
)
options = StandardInsightRequest(number='12345678900', country_code='US', cnam=True)
response = number_insight.standard_number_insight(options)
response = number_insight.get_standard_info(options)
assert response.status == 0
assert response.status_message == 'Success'
assert response.current_carrier.network_code == '23415'
Expand Down
3 changes: 3 additions & 0 deletions video/CHANGES.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# 1.0.3
- Make the filter optional in `Video.list_archives` and `Video.list_broadcasts`

# 1.0.2
- Update dependency versions

Expand Down
2 changes: 1 addition & 1 deletion video/src/vonage_video/_version.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = '1.0.2'
__version__ = '1.0.3'
10 changes: 5 additions & 5 deletions video/src/vonage_video/video.py
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ def list_experience_composers(
"""Lists Experience Composers associated with your Vonage application.
Args:
filter (ListExperienceComposersFilter): Filter for the Experience Composers.
filter (ListExperienceComposersFilter, Optional): Filter for the Experience Composers.
Returns:
tuple[list[ExperienceComposer], int, Optional[int]]: A tuple containing a list of experience
Expand Down Expand Up @@ -358,12 +358,12 @@ def stop_experience_composer(self, experience_composer_id: str) -> None:

@validate_call
def list_archives(
self, filter: ListArchivesFilter
self, filter: ListArchivesFilter = ListArchivesFilter()
) -> tuple[list[Archive], int, Optional[int]]:
"""Lists archives associated with a Vonage Application.
Args:
filter (ListArchivesFilter): The filters for the archives.
filter (ListArchivesFilter, Optional): The filters for the archives.
Returns:
tuple[list[Archive], int, Optional[int]]: A tuple containing a list of archive objects,
Expand Down Expand Up @@ -513,12 +513,12 @@ def change_archive_layout(self, archive_id: str, layout: ComposedLayout) -> Arch

@validate_call
def list_broadcasts(
self, filter: ListBroadcastsFilter
self, filter: ListBroadcastsFilter = ListBroadcastsFilter()
) -> tuple[list[Broadcast], int, Optional[int]]:
"""Lists broadcasts associated with a Vonage Application.
Args:
filter (ListBroadcastsFilter): The filters for the broadcasts.
filter (ListBroadcastsFilter, Optional): The filters for the broadcasts.
Returns:
tuple[list[Broadcast], int, Optional[int]]: A tuple containing a list of broadcast objects,
Expand Down

0 comments on commit 6ee22e6

Please sign in to comment.