Fix nullptr check for hid input data

VoodooSMBus · Oct 18, 2024 · afa2840 · afa2840
1 parent 9461db4
commit afa2840
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/VoodooRMI/Functions/F11.cpp b/VoodooRMI/Functions/F11.cpp
@@ -46,7 +46,7 @@ void F11::attention(AbsoluteTime time, UInt8 *data[], size_t *size)
     size_t fingers;
     UInt8 finger_state;
 
-    if (data) {
+    if (*data) {
         if (*size < attn_size) {
             IOLogError("F11 attention larger than remaining data");
             return;

diff --git a/VoodooRMI/Functions/F12.cpp b/VoodooRMI/Functions/F12.cpp
@@ -272,7 +272,7 @@ void F12::attention(AbsoluteTime time, UInt8 *data[], size_t *size)
     if (!data1)
         return;
 
-    if (data) {
+    if (*data) {
         if (*size < attn_size) {
             IOLogError("F12 attention larger than remaining data");
             return;

diff --git a/VoodooRMI/Functions/Input/RMIFunction.cpp b/VoodooRMI/Functions/Input/RMIFunction.cpp
@@ -42,7 +42,7 @@ bool RMIFunction::start(IOService *provider) {
 }
 
 bool RMIFunction::getInputData(UInt8 dest[], size_t destSize, UInt8 *srcData[], size_t *srcSize) {
-    if (srcData) {
+    if (*srcData) {
         if (*srcSize < destSize) {
             IOLogError("%s Attention size smaller than expected", getName());
             return false;