Final Assembly Rendering #109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is as far as I can take the final assembly renders without someone else testing and giving feedback. There are some aspects of the code that I am not crazy about, but some of it is due to technical debt from what we have already done. It does work, as you can see from the assembly renders below. They are in the order they were automatically generated, from top to bottom, showing each sequential assembly step for a configuration involving a RPi 4B, a NUC and another RPi 4B, in that order. The reason the NUC is installed first is that it is a "broad" shelf and must be inserted from the top before the top plate is installed.
|
|
The renders look perfect! It'll take me a bit of time to find time to go through the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds generation of final assembly renders, in a step-by-step fashion.