Play match sounds through ambient sound category #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgeberrex
requested changes
Feb 3, 2021
There was a problem hiding this comment.
These changes are not actually doing anything as volume values higher than 1 don't actually increase the volume, they just extend the distance the sound can be heard from so it will still be just as loud.
A solution could perhaps be to play sounds on the ambient sound category (method) so players can control the volume without having to change the master volume. It would also be a good opportunity to do the same with other modules like the CTW module
benrobson
changed the title
jorgeberrex
changed the title
jorgeberrex
approved these changes
Feb 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved sound values from 1000 to 100, making values default.
In reference to #658