New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to have same behaviour like SymSpellpy #2

Merged

Wavesonics merged 2 commits into Wavesonics:main from alexsawa:main

Apr 3, 2024

Contributor

alexsawa commented Apr 2, 2024

Hello, we're really looking forward to use your library but we found some differences to the current python implementation that we use.

in SpellHelper: We think that you need to pass the changed key-string to the edit function and not the original key, because the maxEditDistance wouldn't catch.
in SymSpellCheck: In SymSpellPy the original phrase isn't included in the candidates.

thank you for your work and we are looking forward to your feedback

alexsawa added 2 commits

April 2, 2024 14:30


          Fix passing substring key instead of original key

2a36fc5


          Fix exclude original phrase from candidates

5515b71

Wavesonics merged commit 3a13e78 into Wavesonics:main

1 check passed

Owner

Wavesonics commented Apr 3, 2024

Great, thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet