Skip to content

Commit

Permalink
Merge branch '15-include-navigation'
Browse files Browse the repository at this point in the history
  • Loading branch information
Dierk Koenig committed Nov 30, 2024
2 parents 8ee77b0 + 27d0cb0 commit 0f27756
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions docs/src/kolibri/navigation/projector/siteProjector.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,8 @@ const SiteProjector = siteController => {
setTimeout( _time => { // give the passivation anim some time
page.contentElement.classList.remove("passivate"); // just to be sure
passiveContentElement.innerHTML = ""; // remove all children
page.styleElement.remove(); // proper cleanup, even though it should not be needed
// Note that while an overlapping page transition animation runs, the style elements from
// both pages are still in the head. So it is still best practice to user proper css nesting
// as in the examples to avoid conflicts.
// we do not remove the page styleElement because of issues when
// passivation and re-activation styling overlaps
}, page.passivationMs);
});

Expand Down

0 comments on commit 0f27756

Please sign in to comment.