Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass UnverifiedReplyError again for end role #346

Merged

Conversation

iFergal
Copy link
Collaborator

@iFergal iFergal commented Jan 7, 2025

#344 was wrong because UnverifiedReplyError is thrown for insufficient signatures (e.g. multi-sig). Adjusted to only return 400 for invalid signatures.

Copy link
Contributor

@kentbull kentbull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kentbull kentbull merged commit f4a21b3 into WebOfTrust:main Jan 10, 2025
3 checks passed
@iFergal iFergal deleted the fix/endRoleCorrectExceptions branch January 10, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants