-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade deps to prep for 0.2.0-rc1 release #348
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #348 +/- ##
==========================================
- Coverage 93.77% 93.71% -0.06%
==========================================
Files 37 37
Lines 8288 8293 +5
==========================================
Hits 7772 7772
- Misses 516 521 +5 ☔ View full report in Codecov by Sentry. |
458c29e
to
597746a
Compare
@iFergal sounds good to me, it's now changed to To slightly optimize image size I swapped out alpine-sdk for gcc. Only the gcc dependency is needed in order to properly link libsodium. If it weren't for linking libsodium then we wouldn't need gcc, which was the entire reason alpine-sdk was included. |
597746a
to
cb83dfe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Not sure if you're still going to update any docs on the env vs config file but not critical.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Yes, I'll update the docs. Looks like I need to fix merge conflicts anyway. Thanks for the approval @2byrds |
cb83dfe
to
0480888
Compare
@iFergal see the docs I added in the PR. You can |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This does a few things:
getFelItemPreIter
return tuple)scripts/keri/cf/keria.json
with sample tock configuration.