Feat handle sigterm #350

kentbull · 2025-01-13T15:33:24Z

missed the requests package.

This uses lifecycle methods appropriately to set up the signal handlers, mark the GracefulShutdownDoer as done when the shutdown flag is set, and tear down the Doist in the Doer.exit() method

Since the Doist loop listens for the KeyboardInterrupt exception then it effectively handles the Ctrl-C SigInt interrupt already which means the shutdown handler only has to handle the SigTerm signal.

feat: shut down agents gracefully

codecov · 2025-01-13T15:35:50Z

Codecov Report

Attention: Patch coverage is 71.32867% with 41 lines in your changes missing coverage. Please review.

Project coverage is 93.51%. Comparing base (18d3ad7) to head (170398c).
Report is 45 commits behind head on main.

Files with missing lines	Patch %	Lines
src/keria/app/agenting.py	70.12%	23 Missing ⚠️
src/keria/app/serving.py	39.28%	17 Missing ⚠️
tests/app/test_agenting.py	97.36%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #350      +/-   ##
==========================================
+ Coverage   93.06%   93.51%   +0.45%     
==========================================
  Files          36       37       +1     
  Lines        7121     8263    +1142     
==========================================
+ Hits         6627     7727    +1100     
- Misses        494      536      +42

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lenkan and others added 8 commits December 11, 2024 14:27

feat: handle sigterm

6f2f0be

remove redundant runController call

4d68393

feat: shut down agents gracefully

0383dfb

feat: add graceful shutdown handler and clean up agent start code

dc25299

refactor: DoDoer -> Doer for GracefulShutdownDoer

42ac5c8

This uses lifecycle methods appropriately to set up the signal handlers, mark the GracefulShutdownDoer as done when the shutdown flag is set, and tear down the Doist in the Doer.exit() method

refactor: remove redundant SigInt handler

b722e09

Since the Doist loop listens for the KeyboardInterrupt exception then it effectively handles the Ctrl-C SigInt interrupt already which means the shutdown handler only has to handle the SigTerm signal.

Merge pull request #1 from kentbull/feat-handle-sigterm

84987f9

feat: shut down agents gracefully

ci: add requests to tests

170398c

kentbull closed this Jan 13, 2025

kentbull deleted the feat-handle-sigterm branch January 13, 2025 15:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat handle sigterm #350

Feat handle sigterm #350

kentbull commented Jan 13, 2025

codecov bot commented Jan 13, 2025

Feat handle sigterm #350

Feat handle sigterm #350

Conversation

kentbull commented Jan 13, 2025

codecov bot commented Jan 13, 2025

Codecov Report