Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: api to add new loc scheme #352

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

iFergal
Copy link
Collaborator

@iFergal iFergal commented Jan 17, 2025

This allows us to add new location/URL entries for endpoint identifiers that have a role.

I'll be using it to allow an issuer to add a schema discovery endpoint using the new indexer role - WebOfTrust/keripy#920 - with itself as the eid. So the URL can be retrieved via the base OOBI http://keria.com/{controllerPre}. (not .../agent/{agentPre})

This can be extended to have a proper way to retrieve the endpoint given the OOBI, but for my purposes right now it's OK to just parse the OOBI GET response because it's just for fetching SAIDs.

@iFergal iFergal requested a review from 2byrds January 17, 2025 20:04
@iFergal iFergal self-assigned this Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 98.31933% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.77%. Comparing base (ab20766) to head (4d6b361).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/keria/app/aiding.py 96.66% 1 Missing ⚠️
src/keria/core/longrunning.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #352      +/-   ##
==========================================
+ Coverage   93.71%   93.77%   +0.06%     
==========================================
  Files          37       37              
  Lines        8293     8407     +114     
==========================================
+ Hits         7772     7884     +112     
- Misses        521      523       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@2byrds 2byrds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants