-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: enrich package.json #298
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #298 +/- ##
=======================================
Coverage 83.63% 83.63%
=======================================
Files 48 48
Lines 4235 4235
Branches 1055 1055
=======================================
Hits 3542 3542
Misses 663 663
Partials 30 30 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to do this, can you run npm install
locally on your machine to ensure package-lock.json is updated with the new version?
Otherwise, the idea was that the version field on the main
branch is the next minor/major version. Then you publish pre-releases from that by temporarily doing an in place edit in package.json before npm publish. That way, you can implement a workflow that publishes a pre-release on every commit to main, and every git tag. To elaborate:
version: 0.3.0
on package.json on main.- Commit with sha
abc123
is pushed to main. - Workflow triggers and publishes
0.3.0-abc123
to npm - Commit with sha
zyx123
is pushed to main. - Workflow triggers and publishes
0.3.0-xyz123
to npm - Repeat n number of times
- Maintainer decides to publish a beta tag:
- Create git tag
0.3.0-dev.1
- This triggers the workflow that publishes
0.3.0-dev.1
to npm
- Create git tag
- Maintainer decides to publish 0.3.0:
- Create git tag
0.3.0
- This triggers the workflow that publishes
0.3.0
to npm - Create new commit on main that changes
version: 0.4.0
. - Any bug fixes to
0.3.x
can be branched of from the0.3.0
tag.
- Create git tag
I did some work on this before: #260 (comment) However, the current |
30f9bcf
to
8ff1376
Compare
8ff1376
to
941a7e2
Compare
Bump version to 0.3.0-dev0 (latest code from today's
main
branch) and enrich the package.json with useful package metadata to support discovery via NPM.