What do we need to complete the aria coverage of web components? #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Westbrook
commented
May 17, 2022
| <!-- https://leobalter.github.io/cross-root-aria-delegation/ doesn't currently include 'role', but should? --> | ||
| <!-- https://leobalter.github.io/cross-root-aria-delegation/ doesn't currently include 'aria-controls', but should? --> | ||
| <!-- https://leobalter.github.io/cross-root-aria-delegation/ doesn't currently include 'aria-activedescendant', but should? --> | ||
| <input type="text" autoAriaLabelledby autoRole autoAriaExpanded autoActivedescendant> |
There was a problem hiding this comment.
Suggested change
| <input type="text" autoAriaLabelledby autoRole autoAriaExpanded autoActivedescendant> | |
| <input type="text" autoAriaLabelledby autoRole autoAriaExpanded autoAriaActivedescendant autoAriaControls> |
Westbrook
commented
May 17, 2022
| for="input" | ||
| id="label" | ||
| > | ||
| <!-- I've not seen talk of offering "for" functionality on other elements, so we likely need to leverage labelledby instead --> |
There was a problem hiding this comment.
for would come from Customized Built-ins, which won't ship.
Can it also come from ElementMixins as it would be particularly nice for the relationship to bind with the click + focus forwarding, etc of a label, as well.
Westbrook
commented
May 17, 2022
Comment on lines
+21
to
+24
| <!-- https://leobalter.github.io/cross-root-aria-delegation/ doesn't currently include 'aria-labelledby', but should? --> | ||
| <!-- https://leobalter.github.io/cross-root-aria-delegation/ doesn't currently include 'role', but should? --> | ||
| <!-- https://leobalter.github.io/cross-root-aria-delegation/ doesn't currently include 'aria-controls', but should? --> | ||
| <!-- https://leobalter.github.io/cross-root-aria-delegation/ doesn't currently include 'aria-activedescendant', but should? --> |
There was a problem hiding this comment.
These are based on AriaMixin which doesn't include any ID ref attributes, is there a mixin for that? Can we cover these? Are there centralized somewhere for easy inclusion here?
Westbrook
commented
May 17, 2022
| #shadow-root | ||
| <ul role="listbox"> | ||
| <!-- OP skipped over the inability to use this DOM structure, but no need to nitpick --> | ||
| <!-- Placing the role here implies that we can reflect the element out of the shadow DOM in some way, |
There was a problem hiding this comment.
This role might ONLY manage down in a way that it wouldn't need to be reflected. Review with browsers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.