-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create-targz script fixes #1
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This script is pretty old. Check against https://github.com/WhitewaterFoundry/pengwin-rootfs-builds/blob/master/create-targz.sh if anything important is left. Recently we migrated pengwin to Debian 12. I agree to have another script apart from the main build system to customize for user builds.
@@ -31,10 +35,10 @@ sudo chroot $DIST /bin/bash -c "echo 'Defaults lecture_file = /etc/sudoers.lectu | |||
sudo chroot $DIST /bin/bash -c "echo 'Enter your UNIX password below. This is not your Windows password.' > /etc/sudoers.lecture" | |||
|
|||
# remove unnecessary packages in initial image | |||
sudo chroot $DIST apt-get -y -q remove systemd dmidecode --allow-remove-essential | |||
#sudo chroot $DIST apt-get -y -q remove systemd dmidecode --allow-remove-essential |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#sudo chroot $DIST apt-get -y -q remove systemd dmidecode --allow-remove-essential |
@@ -31,10 +35,10 @@ sudo chroot $DIST /bin/bash -c "echo 'Defaults lecture_file = /etc/sudoers.lectu | |||
sudo chroot $DIST /bin/bash -c "echo 'Enter your UNIX password below. This is not your Windows password.' > /etc/sudoers.lecture" | |||
|
|||
# remove unnecessary packages in initial image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# remove unnecessary packages in initial image |
|
||
# clean up any orphaned apt dependencies | ||
sudo chroot $DIST apt-get -y -q autoremove | ||
#sudo chroot $DIST apt-get -y -q autoremove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This helps to have a smaller image, why is being commented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was trying to remove required packages/dependencies that was causing apt to throw errors. There's probably a better resolution than commenting out autoremove, but I'm going to work on getting the build process to work with the non-legacy rootfs repo you mentioned before working on this PR further. If I can't get it to work, I'll fall back on this one (which uses cdebootstrap instead of debootstrap)
@@ -6,6 +6,7 @@ BUILDIR=$(pwd) | |||
TMPDIR=$(mktemp -d) | |||
ARCH="" | |||
DIST="testing" | |||
mkdir -p $TMPDIR/$DIST | |||
cd $TMPDIR | |||
|
|||
function build { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make bash / sh compliant
function build { | |
function build() { |
Related to WhitewaterFoundry/Pengwin#771