allow to install multiple versions of the same packages #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeertvanHorrik
requested changes
Jan 15, 2025
| public static class IPackageInstallationServiceExtensions | ||
| { | ||
| [Time] | ||
| public static async Task<InstallerResult> InstallAsync( |
There was a problem hiding this comment.
This is a breaking change and requires recompilation of the app.
| @@ -0,0 +1,17 @@ | |||
| namespace Orc.NuGetExplorer.Models; | |||
| { | ||
| // Track packages which already installed and make sure only one version of package exists | ||
| var resolver = new Resolver.PackageResolver(); | ||
| availablePackagesToInstall = await resolver.ResolveWithVersionOverrideAsync(resolverContext, project, DependencyBehavior.Ignore, |
There was a problem hiding this comment.
Dependency behavior is changed here, which is not good
There was a problem hiding this comment.
oops, sorry
forgot to change it back
ceo1647
approved these changes
Jan 15, 2025
GeertvanHorrik
approved these changes
Jan 15, 2025
|
Thanks for review guys |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.