Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove repetitive words #1270

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

chore: remove repetitive words #1270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/authentication/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

Our production authentication implementation is provided by Firebase Auth. Auth is registered in the background script and can be used by content scripts over the remote functions interface.

Authentication allows privileged and authorized access of specific features. Including the setup of user-protected multi-device synchronisation channels, and granting premium features to verified subscribed users. As well as a Single Sign-On experience across other Memex services, e.g. posting the the support forum.
Authentication allows privileged and authorized access of specific features. Including the setup of user-protected multi-device synchronisation channels, and granting premium features to verified subscribed users. As well as a Single Sign-On experience across other Memex services, e.g. posting the support forum.

## Consuming Auth

Expand Down Expand Up @@ -70,7 +70,7 @@ Providing an interface to login is most easily handled by delegating to the UI l

We import a `StyledFirebaseAuth from 'react-firebaseui/StyledFirebaseAuth'`. The slight caveat here is the Firebase app object needs to be re-initialised in this script's scope, so that this UI library can use it directly (using the Firebase app already setup in the background script and trying to serialise it over the ipc channel is problematic). This just means importing firebase with it's config by way of `import { firebase } from 'src/util/firebase-app-initialized'` and providing the `StyledFirebaseAuth` with the param `firebaseAuth={firebase.auth()}`.

The backend Firebase app will will react to changes in the Authentication triggered above.
The backend Firebase app will react to changes in the Authentication triggered above.

## Subscription

Expand Down
2 changes: 1 addition & 1 deletion src/common-ui/components/TextInputControlled.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ class TextInputControlled extends React.Component<
}

private handleInputTextEvent(e: ReTargetedTextElementEvent) {
// Here we take advantage of the the e.key either being a single character descriptor like 'A','?','0',etc
// Here we take advantage of the e.key either being a single character descriptor like 'A','?','0',etc
// or a key description like 'Enter', 'Backspace', etc. Single chars are for input, others are not.
if (e.key.length <= 1 && !(e.ctrlKey || e.metaKey)) {
this.handleInput(e.key)
Expand Down