Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Symbols: Block 2.X.1.1 and Penetrate 2.X.1.17 #65

Closed
wants to merge 3 commits into from
Closed

Added Symbols: Block 2.X.1.1 and Penetrate 2.X.1.17 #65

wants to merge 3 commits into from

Conversation

wcmatthysen
Copy link
Member

@wcmatthysen wcmatthysen commented Jul 23, 2019 •
edited
Loading

Description of the Change

Created a new-pull request from the changes in upstream pull-request #134. New symbols namely Block 2.X.1.1 and Penetrate 2.X.1.17 were added by @mziolkowski.

Why Should This Be In Core?

The Tactical Graphic database should be larger.

Benefits

Another useful symbol in the code.

Potential Drawbacks

None

Applicable Issues

None

mziolkowski and others added 3 commits October 3, 2017 17:58
@mziolkowski
Added Symbols: Block 2.X.1.1 and Penetrate 2.X.1.17
9293690
@wcmatthysen
Fixed formatting in TacticalGraphics.
8046ea1
@wcmatthysen
Fixed javadoc of TaskBLetterShape.
ae93d8a 
The javadoc parser in the latest versions of Java is strict and won't
allow a self-closing paragraph tag. This is fixed by changing it to an
opening and closing tag pair.
@wcmatthysen wcmatthysen added the enhancement New feature or request label Jul 23, 2019
@wcmatthysen wcmatthysen mentioned this pull request Jul 23, 2019
Open
@wcmatthysen wcmatthysen changed the title Add block and penetrate symbol Added Symbols: Block 2.X.1.1 and Penetrate 2.X.1.17 Jul 23, 2019
@wcmatthysen
Copy link
Member Author

wcmatthysen commented Jul 23, 2019 •
edited
Loading

Note: this is not ready to merge yet. I picked up a bug when running the TacticalGraphics example. When the positions of the penetrate symbol is swapped with the block symbol so that the penetrate symbol's orientation is rotated 180-degrees the arrows are incorrectly drawn. We need to fix this before we can merge. We should also probably add setter methods to control the arrow's angle and lengths. This is present if you look at the AttackByFirePosition class.

@EMaksymenko
Copy link
Member

Hi @wcmatthysen,

Any news about this PR status?

@wcmatthysen
Copy link
Member Author

Hi @wcmatthysen,

Any news about this PR status?

Hi @ComBatVision, you can have a look at the code and fix it up if you need it in your project. I'm not working on WorldWind at this point in time anymore.

@gbburkhardt
Copy link
Member

@ComBatVision: please merge this. You might want to give me merge privileges. Thanks.

@EMaksymenko
Copy link
Member

EMaksymenko commented Dec 27, 2022 via email

@gbburkhardt gbburkhardt mentioned this pull request Jan 14, 2023
Merged
@gbburkhardt
Copy link
Member

Superseded by pull request 81.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wcmatthysen @EMaksymenko @gbburkhardt @mziolkowski