Prevent duplicate shoutouts #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored Chat Handling to use a handler pattern, allowing for registration of many handlers for chat messages. Some will process all messages, some will process and then prevent further execution. - Refactored ShoutOut interval timer to use a self-scheduling pattern, this allows us to have it re-schedule for a newly updated time. - Moved ShoutOut logic into the GU object - Updated ShoutOut logic to prevent it from shouting out if the last person to talk was the broadcaster and the last time they talked was about the last time the shout out was sent.
pironic
added a commit
that referenced
this pull request
Sep 25, 2014
Prevent duplicate shoutouts regardless of time thereby fixing issue #1
pironic
added a commit
that referenced
this pull request
Sep 25, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1