jetbrains please add base32 decoding to kotlin stdlib already

X1nto · Oct 29, 2023 · 77e7316 · 77e7316
1 parent 67a7a3a
commit 77e7316
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/app/src/main/java/com/xinto/mauth/core/otp/transformer/DefaultKeyTransformer.kt b/app/src/main/java/com/xinto/mauth/core/otp/transformer/DefaultKeyTransformer.kt
@@ -2,9 +2,9 @@ package com.xinto.mauth.core.otp.transformer
 
 import org.apache.commons.codec.binary.Base32
 
-class DefaultKeyTransformer(
-    private val base32: Base32
-) : KeyTransformer {
+class DefaultKeyTransformer : KeyTransformer {
+
+    private val base32 = Base32()
 
     override fun transformToBytes(key: String): ByteArray {
         val trimmed = key.trim()

diff --git a/app/src/main/java/com/xinto/mauth/di/MauthDI.kt b/app/src/main/java/com/xinto/mauth/di/MauthDI.kt
@@ -24,7 +24,6 @@ import com.xinto.mauth.ui.screen.pinremove.PinRemoveViewModel
 import com.xinto.mauth.ui.screen.pinsetup.PinSetupViewModel
 import com.xinto.mauth.ui.screen.qrscan.QrScanViewModel
 import com.xinto.mauth.ui.screen.settings.SettingsViewModel
-import org.apache.commons.codec.binary.Base32
 import org.koin.android.ext.koin.androidContext
 import org.koin.androidx.viewmodel.dsl.viewModelOf
 import org.koin.core.module.dsl.singleOf
@@ -36,9 +35,7 @@ object MauthDI {
     val CoreModule = module {
         singleOf(::DefaultOtpGenerator) bind OtpGenerator::class
         singleOf(::DefaultOtpUriParser) bind OtpUriParser::class
-        single {
-            DefaultKeyTransformer(Base32())
-        } bind KeyTransformer::class
+        singleOf(::DefaultKeyTransformer) bind KeyTransformer::class
         singleOf(::DefaultSettings) bind Settings::class
         singleOf(::DefaultAuthManager) bind AuthManager::class
     }