Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point Reporting Mode tests to xrplcluster #494

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Conversation

nkramer44
Copy link
Collaborator

ReportingModeMainnetEnvironment was previously pointed at https://s2-reporting.riple.com which was recently shut down. https://xrplcluster.com is powered by reporting mode servers, so this PR changes ReportingModeMainnetEnvironment to point to xrplcluster.com

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7f40733) 91.10% compared to head (8e43c5d) 91.10%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #494   +/-   ##
=========================================
  Coverage     91.10%   91.10%           
  Complexity     1626     1626           
=========================================
  Files           319      319           
  Lines          4553     4553           
  Branches        377      377           
=========================================
  Hits           4148     4148           
  Misses          276      276           
  Partials        129      129           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sappenin
Copy link
Collaborator

sappenin commented Nov 16, 2023

Looks like the Reporting IT failed due to Clawback and AMM, so that feels like a "passing test" (i.e., shouldn't block this PR). We should probably make a way to twiddle features off for a given environment. I've updated #266 with this idea.

@nkramer44 can you post here if this should merge via an admin override exception (for now)?

@nkramer44
Copy link
Collaborator Author

@sappenin yes, we've been merging PRs that only fail testnet reporting ITs due to clawback and AMMs, and have no problems doing so here. Merging.

@nkramer44 nkramer44 merged commit f54190c into main Nov 20, 2023
17 of 19 checks passed
@nkramer44 nkramer44 deleted the nk/fix-reporting-test branch November 20, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants