Serialize non-absent AccountSet domain values
#564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #564 +/- ##
=========================================
Coverage 92.02% 92.02%
Complexity 1841 1841
=========================================
Files 382 382
Lines 5106 5106
Branches 433 433
=========================================
Hits 4699 4699
Misses 272 272
Partials 135 135 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To unset the
Domainfield on anAccountRoot, you have to setAccountSet.domainto an empty String. In xrpl4j, the Jackson ObjectMapper is configured globally to only include NON_EMPTY fields, which means thatAccountSet.domainwasn't getting serialized to JSON if it was an empty string, which means that it didn't show up in the binary serialization of the transaction. Therefore, when developers correctly setAccountSet.domainto an empty string to clear the AccountRoot field, the transaction would end up being a no-op becauseDomainwasn't present in the serialized transaction.