-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PC-207] 매칭 상세 보기 Value Talk Ui 구현 #15
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sksowk156
added
UI/UX 🎨
디자인 시스템, 디자인 리소스 관련 코드 🎨
리뷰 원해요🔥
피어의 리뷰를 기다리는 ing.. 🔥
ㅈㅎ찐혁 🌙
훗날 세상을 아우를 남자, sksowk156
labels
Dec 29, 2024
tgyuuAn
reviewed
Dec 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
진혁님 고생하셨습니다~~~~
큰 변경사항은 없구 사소한 컨벤션 관련해서 코멘트를 남겼어요!
저도 얼른 바텀 네비 관련해서 UI 완성해서 PR 올려볼게용~~~
Comment on lines
74
to
83
val bodySSB: TextStyle = TextStyle( | ||
fontFamily = PretendardSemiBold, | ||
fontSize = 14.sp, | ||
lineHeight = 18.sp, | ||
lineHeight = 20.sp, | ||
), | ||
val bodySM: TextStyle = TextStyle( | ||
fontFamily = PretendardMedium, | ||
fontSize = 14.sp, | ||
lineHeight = 18.sp, | ||
lineHeight = 20.sp, | ||
), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
feature/matching/src/main/java/com/puzzle/matching/detail/MatchingDetailRoute.kt
Show resolved
Hide resolved
feature/matching/src/main/java/com/puzzle/matching/detail/MatchingDetailRoute.kt
Outdated
Show resolved
Hide resolved
feature/matching/src/main/java/com/puzzle/matching/detail/MatchingDetailRoute.kt
Outdated
Show resolved
Hide resolved
feature/matching/src/main/java/com/puzzle/matching/detail/MatchingDetailRoute.kt
Outdated
Show resolved
Hide resolved
feature/matching/src/main/java/com/puzzle/matching/detail/MatchingDetailRoute.kt
Show resolved
Hide resolved
feature/matching/src/main/java/com/puzzle/matching/detail/MatchingDetailRoute.kt
Show resolved
Hide resolved
feature/matching/src/main/java/com/puzzle/matching/detail/contract/MatchingDetailState.kt
Outdated
Show resolved
Hide resolved
sksowk156
changed the title
Feature/sksowk156/pc 207
[PC-207] 매칭 상세 보기 Value Talk Ui 구현
Dec 30, 2024
tgyuuAn
approved these changes
Dec 30, 2024
tgyuuAn
added
머지 해도될듯염🌟
현재 코드를 기존 코드에 합쳐도 될 것 같다라고 판단..! 🌟
and removed
리뷰 원해요🔥
피어의 리뷰를 기다리는 ing.. 🔥
labels
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PC-207
1. ⭐️ 변경된 내용
2. 🖼️ 스크린샷(선택)
KakaoTalk_20241230_023532192.mp4
3. 💡 알게된 부분
제가 생각했던 것과 다르게 AppBar(저희는 header)와 그 아래에 있는 LazyColumn가 하나로 움직이는게 아니라 각각의 위치를 offset으로 관리한다는 걸 알게 되었어요!
참고
공식문서
등을 참고했습니다
4. 📌 이 부분은 꼭 봐주세요!
현재는 ' WindowCompat.setDecorFitsSystemWindows(window, true) ' 로 상태바를 덮지 못하게 해두었는데, UI에 따라 상태바를 덮을 수 있게 해야할 것 같아요!