Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PC-253] 패키지 재정리, Auth 화면 생성 #22

Merged
merged 5 commits into from
Jan 4, 2025

Conversation

sksowk156
Copy link
Contributor

@sksowk156 sksowk156 commented Jan 4, 2025

PC-253

1. ⭐️ 변경된 내용

  • Matching, Auth 쪽 패키지를 정리
  • Auth 화면 생성

2. 📌 이 부분은 꼭 봐주세요!

  • 패키지 단위를 재정의 했는데 의견 부탁드립니다!

@sksowk156 sksowk156 added UI/UX 🎨 디자인 시스템, 디자인 리소스 관련 코드 🎨 리뷰 원해요🔥 피어의 리뷰를 기다리는 ing.. 🔥 ㅈㅎ찐혁 🌙 훗날 세상을 아우를 남자, sksowk156 labels Jan 4, 2025
@sksowk156 sksowk156 requested a review from tgyuuAn January 4, 2025 06:25
@sksowk156 sksowk156 self-assigned this Jan 4, 2025
Copy link
Member

@tgyuuAn tgyuuAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

진혁님 바뀐 패키지 구조 너무 좋은 것 같아요!

page도 너무 좋은데 graph 어떨까요?!?!?!?

정말 조아요~~~~

@Assisted initialState: AuthState,
private val navigationHelper: NavigationHelper,
) : MavericksViewModel<AuthState>(initialState) {
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p4) EOL하나 있네용, 근데 지금 고치지 말고 나중에 ViewModel 작업할 때 하나 넣어주세요!~

@tgyuuAn tgyuuAn added 머지 해도될듯염🌟 현재 코드를 기존 코드에 합쳐도 될 것 같다라고 판단..! 🌟 and removed 리뷰 원해요🔥 피어의 리뷰를 기다리는 ing.. 🔥 labels Jan 4, 2025
@sksowk156 sksowk156 merged commit ad644b4 into develop Jan 4, 2025
1 check failed
@sksowk156 sksowk156 deleted the feature/sksowk156/PC-253 branch January 4, 2025 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI/UX 🎨 디자인 시스템, 디자인 리소스 관련 코드 🎨 ㅈㅎ찐혁 🌙 훗날 세상을 아우를 남자, sksowk156 머지 해도될듯염🌟 현재 코드를 기존 코드에 합쳐도 될 것 같다라고 판단..! 🌟
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants