[PC-000] suspendRunCatching 추가 #26
Merged
+19
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgyuuAn
added
리뷰 원해요🔥
sksowk156
reviewed
Jan 7, 2025
| @@ -31,8 +32,8 @@ class TermsRepositoryImpl @Inject constructor( | |||
| localTermDataSource.clearAndInsertTerms(termsEntity) | |||
| } | |||
|
|
|||
| override suspend fun getTerms(): Result<List<Term>> = runCatching { | |||
| override suspend fun getTerms(): Result<List<Term>> = suspendRunCatching { | |||
There was a problem hiding this comment.
저번 PR에서 제가 달았던 코멘트의 의미는 get보다 의미 범위가 조금 더 좁은 단어를 말하는 거였어요!ㅎㅎ 제가 요즘 여기저기서 스코프라는 단어를 쓸 일이 좀 있었는데, 아무 생각없이 스코프라는 단어를 썼던 것 같아요 허허... 다음 PR부턴 조금 더 명확한 표현을 쓰도록 할게요...!!!
There was a problem hiding this comment.
아하 괜찮습니다!!
좀 더 좁은 의미가 흠.. 네이밍이 생각이 ㅠㅠㅠㅠㅠㅠㅠㅠㅠㅠㅠㅠㅠㅠ
| localTermDataSource.getTerms() | ||
| .map { it.toDomain() } | ||
| .map(TermEntity::toDomain) |
sksowk156
added
머지 해도될듯염🌟
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. ⭐️ 변경된 내용
2. 🖼️ 스크린샷(선택)
3. 💡 알게된 부분
Github를 돌아다니다가 현우님이 아래와 같은 PR을 작성해주신 것을 확인했어요.
ku-ring/KU-Ring-Android#405
너무 흥미로워서 공유합니다!
레퍼런스
runCatchingthat does not handle aCancellationExceptionbut re-throws it instead. Kotlin/kotlinx.coroutines#1814