Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PC-000] 약관 상세 화면 웹뷰가 렌더링 되기 이전 TopBar가 가려지던 것 해결 #28

Merged
merged 1 commit into from
Jan 9, 2025
Merged

[PC-000] 약관 상세 화면 웹뷰가 렌더링 되기 이전 TopBar가 가려지던 것 해결 #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ android {
defaultConfig {
versionCode = 1
versionName = "1.0.0"
targetSdk = 34
targetSdk = 35

testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"

Expand All @@ -21,8 +21,6 @@ android {
buildConfigField("String", "KAKAO_APP_KEY", "\"${localProperties["KAKAO_APP_KEY"]}\"")
}

packaging { resources { excludes += "/META-INF/*" } }

Comment on lines -24 to -25
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요 녀석 때문에 LayoutInspector가 동작안하고 있었습니다..

제거하니까 동작하더군요!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

허허 저 코드가 항상 뭐하는 코드인지 잘 몰랐는데 한번 찾아봐야겠군요...!!

buildTypes {
release {
signingConfig = signingConfigs.getByName("debug")
Expand Down
2 changes: 0 additions & 2 deletions build-logic/src/main/java/com/puzzle/build/logic/KotlinAndroid.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,6 @@ internal fun Project.configureKotlinAndroid() {
// add("implementation", libs.findLibrary("firebase-analytics").get())
// add("implementation", libs.findLibrary("firebase-crashlytics").get())
// }

packaging { resources.excludes.add("META-INF/*") }
}

configureKotlin()
Expand Down
4 changes: 3 additions & 1 deletion feature/auth/src/main/java/com/puzzle/auth/graph/registration/ui/RegistrationDetailScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.padding
import androidx.compose.runtime.Composable
import androidx.compose.ui.Modifier
import androidx.compose.ui.draw.clipToBounds
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.unit.dp
import com.puzzle.designsystem.R
Expand Down Expand Up @@ -37,7 +38,8 @@ internal fun RegistrationDetailScreen(
url = term.content,
modifier = Modifier
.fillMaxWidth()
.weight(1f),
.weight(1f)
.clipToBounds(),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LayoutInspector 상으로는 레이아웃이 적절하게 배치되어있는데,

아무래도 WebView가 주어진 영역을 침범하는 것 같더라고요.

clipToBounds() 를 적용시키니 바로 해결되었습니다!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

느낌 상으로는 weight(1f)로도 될 거 같은데... 웹뷰만의 특징인건가...?!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

느낌 상으로는 weight(1f)로도 될 거 같은데... 웹뷰만의 특징인건가...?!

그런가봐요.... 잘 모르겠네요 ㅠㅠㅠㅠㅠㅠ

)

PieceSolidButton(
Expand Down
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.