Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for HTTP2 mode & updated SmartStack schema #4002

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ankit864
Copy link
Contributor

@ankit864 ankit864 commented Jan 8, 2025

Support for HTTP2 mode & updated SmartStack schema.

@ankit864 ankit864 requested a review from a team as a code owner January 8, 2025 16:06
@ankit864 ankit864 marked this pull request as draft January 8, 2025 16:10
@ankit864 ankit864 force-pushed the update-mode-http2-support branch from 59007c9 to ceb820d Compare January 8, 2025 16:14
@ankit864 ankit864 marked this pull request as ready for review January 8, 2025 16:20
jfongatyelp
jfongatyelp previously approved these changes Jan 8, 2025
@jfongatyelp
Copy link
Contributor

There may be some other pieces that need updating, e.g. https://github.com/Yelp/paasta/blob/master/paasta_tools/kubernetes_tools.py#L1374-L1389 this seems to only cycle thru all previously-valid service 'mode's :(

You might need to actually run setup_kubernetes_job to find all those places tho

jfongatyelp
jfongatyelp previously approved these changes Jan 9, 2025
@nemacysts
Copy link
Member

related to ^ - probably also want to figure out what we wanna do with:

otherwise, i think these 2 (+ the link @jfongatyelp provided) might be all? (that said, i agree with jfong that running skj with these changes would probably be the best/quickest way to see what else might be missing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants