Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YoastCS: fix some tests not running #316

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

jrfnl
Copy link
Collaborator

@jrfnl jrfnl commented Nov 3, 2023

Files/TestDoubles: bug fix - not all tests were being run

There was a bug in the glob expression used to collect all the test case files, which meant that not all test case files were found and checked during the test runs.

Fixed now. Includes one minor, non-consequential fix to the test expectations.

NamingConventions/NamespaceName: bug fix - not all tests were being run

There was a bug in the glob expression used to collect all the test case files, which meant that not all test case files were found and checked during the test runs.

Fixed now.

jrfnl added 2 commits November 3, 2023 19:25
There was a bug in the `glob` expression used to collect all the test case files, which meant that not all test case files were found and checked during the test runs.

Fixed now. Includes one minor, non-consequential fix to the test expectations.
There was a bug in the `glob` expression used to collect all the test case files, which meant that not all test case files were found and checked during the test runs.

Fixed now.
@jrfnl jrfnl added this to the 3.0 milestone Nov 3, 2023
@coveralls
Copy link

Coverage Status

coverage: 97.815% (+0.4%) from 97.371%
when pulling 85eb928 on JRF/yoastcs-fix-some-tests-not-running
into f84b4aa on develop.

@jrfnl jrfnl merged commit 7f0ba01 into develop Nov 3, 2023
30 checks passed
@jrfnl jrfnl deleted the JRF/yoastcs-fix-some-tests-not-running branch November 3, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants